From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb Date: Tue, 10 Jul 2012 12:32:17 +0530 Message-ID: <4FFBD379.6070606@ti.com> References: <1340884267-28908-1-git-send-email-kishon@ti.com> <1340884267-28908-8-git-send-email-kishon@ti.com> <4FFBC56F.7080007@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "ABRAHAM, KISHON VIJAY" Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net, linux@arm.linux.org.uk, gregkh@linuxfoundation.org, b-cousson@ti.com, tony@atomide.com, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, balbi@ti.com, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, hvaibhav@ti.com List-Id: linux-omap@vger.kernel.org On Tuesday 10 July 2012 12:22 PM, ABRAHAM, KISHON VIJAY wrote: >>> +TWL4030 USB PHY AND COMPARATOR >>> >> + - compatible : Should be "ti,twl4030-usb" >>> >> + - interrupts : The interrupt numbers to the cpu should be specified. >>> >> First >>> >> + interrupt number is the otg interrupt number that raises ID interrupts >>> >> + and VBUS interrupts. The second interrupt number is optional. >>> >> + --supply : phandle to the regulator device tree node. >>> >> + should be vusb1v5, vusb1v8 and vusb3v1 >>> >> + - usb_mode : The mode used by the phy to connect to the controller. "1" >>> >> + specifies "ULPI" mode and "2" specifies "CEA2011_3PIN" mode. >> > >> > >> > Are these standard usb phy modes or something specific to the twl4030 >> > usb phy? > These are standard modes used to connect the phy to the controller. I > think it's used by other chips other than twl4030 (Something in > am35xx??). So would it make sense to document these bindings independent of a given phy and a given controller, so it could be reused and not duplicated in various forms for various different controllers.