From: Romain Naour <romain.naour@smile.fr>
To: Conor Dooley <conor@kernel.org>
Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Romain Naour" <romain.naour@skf.com>
Subject: Re: [PATCH 1/3] arch/arm/boot/dts/dra7-l4.dtsi: add missing unit addresse
Date: Tue, 23 Jan 2024 09:56:16 +0100 [thread overview]
Message-ID: <4bc121c7-ebae-4953-b2bd-c4c343fa8731@smile.fr> (raw)
In-Reply-To: <20240122-extending-identical-9609420a1baa@spud>
Hello,
Le 22/01/2024 à 18:11, Conor Dooley a écrit :
> On Mon, Jan 22, 2024 at 12:19:46PM +0100, Romain Naour wrote:
>> From: Romain Naour <romain.naour@skf.com>
>>
>> phy_gmii_sel node have 'reg' so it must have unit address.
>>
>> Fixes:
>> Warning (unit_address_vs_reg): /ocp/interconnect@4a000000/segment@0/target-module@2000/scm@0/scm_conf@0/phy-gmii-sel: node has a reg or ranges property, but no unit name
>
> Does checkpatch not complain about this "Fixes" tag?
No, but there is a warning due to the too long line.
I removed the Fixes tag.
>
> Also, for all patches in your series, the subject is odd. Running
> `git log` on the files you're changing is a good idea to get off to a
> good start with a subject line.
You're right.
Best regards,
Romain
>
> Thanks,
> Conor.
>
>>
>> Signed-off-by: Romain Naour <romain.naour@skf.com>
prev parent reply other threads:[~2024-01-23 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 11:19 [PATCH 1/3] arch/arm/boot/dts/dra7-l4.dtsi: add missing unit addresse Romain Naour
2024-01-22 11:19 ` [PATCH 2/3] arch/arm/boot/dts/dra7xx-clocks.dtsi: " Romain Naour
2024-01-22 11:19 ` [PATCH 3/3] arch/arm/boot/dts/dra7.dtsi: add missing unit addresses Romain Naour
2024-01-22 17:11 ` [PATCH 1/3] arch/arm/boot/dts/dra7-l4.dtsi: add missing unit addresse Conor Dooley
2024-01-23 8:56 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bc121c7-ebae-4953-b2bd-c4c343fa8731@smile.fr \
--to=romain.naour@smile.fr \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=romain.naour@skf.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox