From: Marc Kleine-Budde <mkl@pengutronix.de>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: wg@grandegger.com, linux-can@vger.kernel.org,
linux-omap@vger.kernel.org, anantgole@ti.com, nsekhar@ti.com
Subject: Re: [PATCH v8] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller
Date: Mon, 20 Aug 2012 12:57:53 +0200 [thread overview]
Message-ID: <50321831.1070106@pengutronix.de> (raw)
In-Reply-To: <5032144C.2090007@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]
On 08/20/2012 12:41 PM, Marc Kleine-Budde wrote:
> On 08/20/2012 10:45 AM, AnilKumar Ch wrote:
>> Add Runtime PM support to C_CAN/D_CAN controller. The runtime PM
>> APIs control clocks for C_CAN/D_CAN IP and prevent access to the
>> register of C_CAN/D_CAN IP when clock is turned off.
>>
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> ---
>> This patch has been tested on AM335X EVM. Due to lack of hardware
>> I am not able to test c_can functionality. I appreciate if anyone
>> can test c_can functionality with this patch.
>>
>> This patch is based on "can-next/master"
>>
>> Changes from v7:
>> - Incorporated Marc's commets on v7
>> * changed device pointer to c_can_priv pointer
>
> looks good.
>
> [...]
>
>> --- a/drivers/net/can/c_can/c_can_platform.c
>> +++ b/drivers/net/can/c_can/c_can_platform.c
>> @@ -32,6 +32,7 @@
>> #include <linux/clk.h>
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> +#include <linux/pm_runtime.h>
>>
>> #include <linux/can/dev.h>
>>
>> @@ -177,8 +178,11 @@ static int __devinit c_can_plat_probe(struct platform_device *pdev)
>> goto exit_free_device;
> ^^^^^^^^^^^^^^^^
>> }
>>
>> + pm_runtime_enable(&pdev->dev);
>> +
>> dev->irq = irq;
>> priv->base = addr;
>> + priv->device = &pdev->dev;
>> priv->can.clock.freq = clk_get_rate(clk);
>> priv->priv = clk;
>>
>> @@ -198,6 +202,7 @@ static int __devinit c_can_plat_probe(struct platform_device *pdev)
>>
>> exit_free_device:
>> platform_set_drvdata(pdev, NULL);
>> + pm_runtime_disable(&pdev->dev);
>
> I think this will end up in a NULL pointer deferf.
Should be no problem, as you're using pdev->dev not priv->device.
Sorry for the noise :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-08-20 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 8:45 [PATCH v8] can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller AnilKumar Ch
2012-08-20 10:41 ` Marc Kleine-Budde
2012-08-20 10:57 ` Marc Kleine-Budde [this message]
2012-08-20 11:03 ` AnilKumar, Chimata
2012-08-20 11:06 ` AnilKumar, Chimata
2012-08-20 11:11 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50321831.1070106@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=anantgole@ti.com \
--cc=anilkumar@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).