From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH v2] of: Modify c_can binding documentation Date: Thu, 06 Sep 2012 11:44:36 +0200 Message-ID: <50487084.9070006@pengutronix.de> References: <1346648074-27025-1-git-send-email-anilkumar@ti.com> <50487005.6090700@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig344EB91950AAC60985F487EF" Return-path: In-Reply-To: <50487005.6090700@pengutronix.de> Sender: linux-can-owner@vger.kernel.org To: AnilKumar Ch Cc: wg@grandegger.com, swarren@wwwdotorg.org, linux-can@vger.kernel.org, linux-omap@vger.kernel.org, anantgole@ti.com, nsekhar@ti.com List-Id: linux-omap@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig344EB91950AAC60985F487EF Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/06/2012 11:42 AM, Marc Kleine-Budde wrote: > On 09/03/2012 06:54 AM, AnilKumar Ch wrote: >> Modify c_can binding documentation according to recent review comments= >> on device tree data addition patches. >> >> Signed-off-by: AnilKumar Ch >> --- >> Changes from v1: >> - Separated from "Add DT for AM33XX devices" patch series >> - Incorporated Stephen Warren's review comments on v1 >> * Removed status and interrupt-parent description from >> c_can.txt file because these are device specific >> parameters. >> >> .../devicetree/bindings/net/can/c_can.txt | 24 +++++++++++= ++++----- >> 1 file changed, 18 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/can/c_can.txt b/Doc= umentation/devicetree/bindings/net/can/c_can.txt >> index a43f083..2c420c2 100644 >> --- a/Documentation/devicetree/bindings/net/can/c_can.txt >> +++ b/Documentation/devicetree/bindings/net/can/c_can.txt >> @@ -10,7 +10,6 @@ Required properties: >> number >> =20 >> Optional properties: >> -- interrupt-parent : The parent interrupt controller >> - ti,hwmods : Must be "d_can" or "c_can", n being the >> instance number >> =20 >> @@ -20,18 +19,31 @@ Future plan is to migrate hwmod data base contents= into device tree >> blob so that, all the required data will be used from device tree dts= >> file. >> =20 >> -Examples: >> +Example: >> =20 >> - d_can@481D0000 { >> +Step1: SoC common .dtsi file >> + >> + d_can1: d_can@481d0000 { >> compatible =3D "bosch,d_can"; >> - reg =3D <0x481D0000 0x1000>; >> - interrupts =3D <55 0x4>; >> + reg =3D <0x481d0000 0x2000>; >> + interrupts =3D <55>; >> interrupt-parent =3D <&intc>; >> + status =3D "disabled"; >> }; >> =20 >> (or) >> =20 >> - d_can@481D0000 { >> + d_can1: d_can@481d0000 { ^^^^^^ This is the typo then? You just posted this patch against arch/arm/boot/dts/am33xx.dtsi: + dcan0: d_can@481cc000 { + compatible =3D "bosch,d_can"; + ti,hwmods =3D "d_can0"; + reg =3D <0x481cc000 0x2000>; + interrupts =3D <52>; + interrupt-parent =3D <&intc>; + status =3D "disabled"; + }; >> compatible =3D "bosch,d_can"; >> ti,hwmods =3D "d_can1"; >> + reg =3D <0x481d0000 0x2000>; >> + interrupts =3D <55>; >> + interrupt-parent =3D <&intc>; >> + status =3D "disabled"; >> + }; >> + >> +Step 2: board specific .dts file >> + >> + &dcan1 { > ^^^^^^ >=20 > Is there an alias for dcan1 =3D=3D d_can1 or is this a typo? >=20 > Marc >=20 >> + status =3D "okay"; >> }; Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig344EB91950AAC60985F487EF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBIcIQACgkQjTAFq1RaXHMdcACfSi4PZFCCFus2O8G6bjy/q8YZ +M4An3tn3ttuheUyUxalcMwDuPFhlFqa =FW7q -----END PGP SIGNATURE----- --------------enig344EB91950AAC60985F487EF--