From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware Date: Mon, 10 Sep 2012 18:34:20 +0200 Message-ID: <504E168C.6060603@ti.com> References: <1347294020-22661-1-git-send-email-mporter@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1347294020-22661-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Matt Porter Cc: Devicetree Discuss , Linux Kernel Mailing List , Linux OMAP List , Linux ARM Kernel List List-Id: linux-omap@vger.kernel.org + Tony Hi Matt, 30 minutes too late for my pull request :-( There are a couple of am33xx patches under discussion, so I'll take them and send a for_3.7/dts-part2 pull request if this is not too late for Tony. On 09/10/2012 06:20 PM, Matt Porter wrote: > On AM33xx, the datasheet and TRM refer to four GPIO instances that > are 0-based, GPIO0-3. Or maybe you should just update the spec to use a 1-based GPIO number like OMAP :-) Regards, Benoit > > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/am33xx.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index bb31bff..1369bfc 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -62,7 +62,7 @@ > reg = <0x48200000 0x1000>; > }; > > - gpio1: gpio@44e07000 { > + gpio0: gpio@44e07000 { > compatible = "ti,omap4-gpio"; > ti,hwmods = "gpio1"; > gpio-controller; > @@ -74,7 +74,7 @@ > interrupts = <96>; > }; > > - gpio2: gpio@4804c000 { > + gpio1: gpio@4804c000 { > compatible = "ti,omap4-gpio"; > ti,hwmods = "gpio2"; > gpio-controller; > @@ -86,7 +86,7 @@ > interrupts = <98>; > }; > > - gpio3: gpio@481ac000 { > + gpio2: gpio@481ac000 { > compatible = "ti,omap4-gpio"; > ti,hwmods = "gpio3"; > gpio-controller; > @@ -98,7 +98,7 @@ > interrupts = <32>; > }; > > - gpio4: gpio@481ae000 { > + gpio3: gpio@481ae000 { > compatible = "ti,omap4-gpio"; > ti,hwmods = "gpio4"; > gpio-controller; >