* serial-omap regression?
@ 2012-09-20 22:56 Kevin Hilman
2012-09-20 23:03 ` Kevin Hilman
2012-09-21 21:49 ` Kevin Hilman
0 siblings, 2 replies; 5+ messages in thread
From: Kevin Hilman @ 2012-09-20 22:56 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-omap
Hi Felipe,
I just noticed today that one of my boards (3530/Overo) was not making
it to the console when using an Debian rootfs (nfsroot) but works fine
with my basic busybox initramfs. Basically, it hangs somewhere between
finishing the userspace init and launching the login shell.
git bisect ended up pointing the finger at a patch in the OMAP serial
series[1]. I didn't debug this any further. Any ideas?
Kevin
72256cbd13904d4b4dbb16f5ec83a3293bb292c5 is the first bad commit
commit 72256cbd13904d4b4dbb16f5ec83a3293bb292c5
Author: Felipe Balbi <balbi@ti.com>
Date: Thu Sep 6 15:45:24 2012 +0300
serial: omap: refactor receive_chars() into rdi/rlsi handlers
receive_chars() was getting too big and too difficult
to follow. By splitting it into separate RDI and RSLI
handlers, we have smaller functions which are easy
to understand and only touch the pieces which they need
to touch.
Tested-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
:040000 040000 69585356cd524953305cfba7d219cd65430a4067 ffdc0c05004afe8b73c1f2c0ba41e412c1faf5f4 M drivers
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: serial-omap regression?
2012-09-20 22:56 serial-omap regression? Kevin Hilman
@ 2012-09-20 23:03 ` Kevin Hilman
2012-09-21 9:28 ` Felipe Balbi
2012-09-21 21:49 ` Kevin Hilman
1 sibling, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2012-09-20 23:03 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-omap
Kevin Hilman <khilman@deeprootsystems.com> writes:
> Hi Felipe,
>
> I just noticed today that one of my boards (3530/Overo) was not making
> it to the console when using an Debian rootfs (nfsroot) but works fine
> with my basic busybox initramfs. Basically, it hangs somewhere between
> finishing the userspace init and launching the login shell.
>
> git bisect ended up pointing the finger at a patch in the OMAP serial
> series[1]. I didn't debug this any further. Any ideas?
>
I forgot to add, this was first noticed when testing with
arm-soc/for-next which has the serial-omap changes pulled in as a
dependency.
Kevin
>
>
> 72256cbd13904d4b4dbb16f5ec83a3293bb292c5 is the first bad commit
> commit 72256cbd13904d4b4dbb16f5ec83a3293bb292c5
> Author: Felipe Balbi <balbi@ti.com>
> Date: Thu Sep 6 15:45:24 2012 +0300
>
> serial: omap: refactor receive_chars() into rdi/rlsi handlers
>
> receive_chars() was getting too big and too difficult
> to follow. By splitting it into separate RDI and RSLI
> handlers, we have smaller functions which are easy
> to understand and only touch the pieces which they need
> to touch.
>
> Tested-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> :040000 040000 69585356cd524953305cfba7d219cd65430a4067 ffdc0c05004afe8b73c1f2c0ba41e412c1faf5f4 M drivers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: serial-omap regression?
2012-09-20 23:03 ` Kevin Hilman
@ 2012-09-21 9:28 ` Felipe Balbi
2012-09-21 9:40 ` Shubhrajyoti
0 siblings, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2012-09-21 9:28 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Felipe Balbi, linux-omap, Shubhrajyoti Datta, Sourav Poddar
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Hi,
On Thu, Sep 20, 2012 at 04:03:50PM -0700, Kevin Hilman wrote:
> Kevin Hilman <khilman@deeprootsystems.com> writes:
>
> > Hi Felipe,
> >
> > I just noticed today that one of my boards (3530/Overo) was not making
> > it to the console when using an Debian rootfs (nfsroot) but works fine
> > with my basic busybox initramfs. Basically, it hangs somewhere between
> > finishing the userspace init and launching the login shell.
> >
> > git bisect ended up pointing the finger at a patch in the OMAP serial
> > series[1]. I didn't debug this any further. Any ideas?
> >
>
> I forgot to add, this was first noticed when testing with
> arm-soc/for-next which has the serial-omap changes pulled in as a
> dependency.
hmmm, Shubhro had written a patch to fix some mistakes on rlsi handler.
Maybe it fixes this problem ?
Shubhro, can you send your patch ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: serial-omap regression?
2012-09-21 9:28 ` Felipe Balbi
@ 2012-09-21 9:40 ` Shubhrajyoti
0 siblings, 0 replies; 5+ messages in thread
From: Shubhrajyoti @ 2012-09-21 9:40 UTC (permalink / raw)
To: balbi; +Cc: Kevin Hilman, linux-omap, Sourav Poddar
On Friday 21 September 2012 02:58 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Sep 20, 2012 at 04:03:50PM -0700, Kevin Hilman wrote:
>> Kevin Hilman <khilman@deeprootsystems.com> writes:
>>
>>> Hi Felipe,
>>>
>>> I just noticed today that one of my boards (3530/Overo) was not making
>>> it to the console when using an Debian rootfs (nfsroot) but works fine
>>> with my basic busybox initramfs. Basically, it hangs somewhere between
>>> finishing the userspace init and launching the login shell.
>>>
>>> git bisect ended up pointing the finger at a patch in the OMAP serial
>>> series[1]. I didn't debug this any further. Any ideas?
>>>
>> I forgot to add, this was first noticed when testing with
>> arm-soc/for-next which has the serial-omap changes pulled in as a
>> dependency.
> hmmm, Shubhro had written a patch to fix some mistakes on rlsi handler.
> Maybe it fixes this problem ?
>
> Shubhro, can you send your patch ?
Yes I am in teh process of testing it.
Will post in an hour.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: serial-omap regression?
2012-09-20 22:56 serial-omap regression? Kevin Hilman
2012-09-20 23:03 ` Kevin Hilman
@ 2012-09-21 21:49 ` Kevin Hilman
1 sibling, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2012-09-21 21:49 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-omap
Not sure if it's related to the cleanup series, but I've also been
seeing a bunch of 'callbacks suppressed messages lately. Is anyone else
seeing this?
Here's an example from a debian nfsfroot boot:
[ 20.044006] tty_init_dev: 59 callbacks suppressed
[ 25.063934] tty_init_dev: 57 callbacks suppressed
[ 38.910552] tty_init_dev: 38 callbacks suppressed
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-21 21:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-20 22:56 serial-omap regression? Kevin Hilman
2012-09-20 23:03 ` Kevin Hilman
2012-09-21 9:28 ` Felipe Balbi
2012-09-21 9:40 ` Shubhrajyoti
2012-09-21 21:49 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).