From: Yegor Yefremov <yegor_sub1@visionsystems.de>
To: Tony Lindgren <tony@atomide.com>
Cc: Dejan Gacnik <dejan.gacnik@gmail.com>,
linux-omap@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Yegor Yefremov <yegorslists@googlemail.com>
Subject: Re: [PATCH] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX
Date: Tue, 25 Sep 2012 10:05:30 +0200 [thread overview]
Message-ID: <506165CA.7070406@visionsystems.de> (raw)
In-Reply-To: <20120925003758.GP28835@atomide.com>
On 25.09.2012 02:37, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [120924 16:17]:
>> On Mon, Sep 24, 2012 at 09:05:11PM +0200, Yegor Yefremov wrote:
>>> On Mon, Sep 24, 2012 at 7:18 PM, Tony Lindgren <tony@atomide.com> wrote:
>>>> * yegorslists@googlemail.com <yegorslists@googlemail.com> [120703 07:26]:
>>>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>>>
>>>>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>>>>> of consistent DMA memory (da8xx frame buffer driver).
>>>>
>>>> Sorry for the delay on this one, looks like this one is
>>>> still valid. I'll apply it.
>>>
>>> Thanks.
>>>
>>> Yegor
>>>
>>>>> Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
>>>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>>>> ---
>>>>> arch/arm/Kconfig | 5 +++--
>>>>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>>>> index e876819..ff14c1e 100644
>>>>> --- a/arch/arm/Kconfig
>>>>> +++ b/arch/arm/Kconfig
>>>>> @@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
>>>>> source "mm/Kconfig"
>>>>>
>>>>> config FORCE_MAX_ZONEORDER
>>>>> - int "Maximum zone order" if ARCH_SHMOBILE
>>>>> - range 11 64 if ARCH_SHMOBILE
>>>>> + int "Maximum zone order"
>>>>> + depends on ARCH_SHMOBILE || SOC_AM33XX
>>>>> + range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
>>>>> default "9" if SA1111
>>>>> default "11"
>>
>> NAK. This patch breaks SA1111 platforms. To see why, read the patch.
>
> OK let's drop this.
How should I change the patch to make it proper? SA1111 is broken anyway:
config FORCE_MAX_ZONEORDER
int "Maximum zone order" if ARCH_SHMOBILE
range 11 64 if ARCH_SHMOBILE
default "9" if SA1111
default "11"
AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE, so SA1111 won't be evaluated (at least if I select SA1111 include/generated/autoconf.h shows "11"). If I add SA1111 to dependency list like this:
depends on ARCH_SHMOBILE || SOC_AM33XX || SA1111
the prompt in "Kernel features" becomes visible, but it doesn't have the default value of "9", but "11".
Am I missing something?
Yegor
next prev parent reply other threads:[~2012-09-25 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 14:20 [PATCH] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX yegorslists
2012-09-24 17:18 ` Tony Lindgren
2012-09-24 19:05 ` Yegor Yefremov
2012-09-24 23:16 ` Russell King - ARM Linux
2012-09-25 0:37 ` Tony Lindgren
2012-09-25 8:05 ` Yegor Yefremov [this message]
2012-09-25 8:14 ` Russell King - ARM Linux
2012-09-25 8:28 ` Yegor Yefremov
2012-09-27 14:12 ` Dejan Gačnik
2012-10-08 20:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506165CA.7070406@visionsystems.de \
--to=yegor_sub1@visionsystems.de \
--cc=dejan.gacnik@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).