From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: paul@pwsan.com, linux-media@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration
Date: Thu, 27 Sep 2012 23:08:09 +0300 [thread overview]
Message-ID: <5064B229.7010707@iki.fi> (raw)
In-Reply-To: <2067951.ZTSQvUdPug@avalon>
Hi Laurent,
Thanks for the review!
Laurent Pinchart wrote:
> Hi Sakari,
>
> Thanks for the patch.
>
> On Thursday 27 September 2012 00:50:35 Sakari Ailus wrote:
>> The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to
>> the actual CSI-2 receivers outside the ISP itself. Allow changing this
>> configuration from the ISP driver.
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
>
> Just one small comment below, otherwise
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>> ---
>> arch/arm/mach-omap2/control.c | 86 +++++++++++++++++++++++++
>> arch/arm/mach-omap2/control.h | 15 +++++
>> arch/arm/mach-omap2/include/mach/control.h | 13 ++++
>> 3 files changed, 114 insertions(+), 0 deletions(-)
>> create mode 100644 arch/arm/mach-omap2/include/mach/control.h
>>
>> diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
>> index 3223b81..11bb900 100644
>> --- a/arch/arm/mach-omap2/control.c
>> +++ b/arch/arm/mach-omap2/control.c
...
>> + cam_phy_ctrl |= mode << shift;
>> +
>> + omap_ctrl_writel(cam_phy_ctrl,
>> + OMAP3630_CONTROL_CAMERA_PHY_CTRL);
>
> This can fit on one line.
I'll fix that for the next version. I noticed there were a few too long
lines, too; I've broken them up where it makes sense, and removed a
useless break statement.
Cheers,
--
Sakari Ailus
sakari.ailus@iki.fi
next prev parent reply other threads:[~2012-09-27 20:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 21:50 [PATCH v2 0/2] OMAP 3 CSI-2 configuration Sakari Ailus
2012-09-26 21:50 ` [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration Sakari Ailus
2012-09-27 9:20 ` Laurent Pinchart
2012-09-27 20:08 ` Sakari Ailus [this message]
2012-10-09 20:50 ` Kevin Hilman
2012-10-09 22:33 ` Sakari Ailus
2012-10-10 0:22 ` Kevin Hilman
2012-09-26 21:50 ` [PATCH v2 2/2] omap3isp: Configure CSI-2 phy based on platform data Sakari Ailus
2012-09-26 22:00 ` Tony Lindgren
2012-09-27 9:52 ` Laurent Pinchart
2012-09-28 0:00 ` Tony Lindgren
2012-09-27 14:38 ` [PATCH] omap3isp: Replace cpu_is_omap3630() with ISP revision check Laurent Pinchart
2012-09-27 23:59 ` Tony Lindgren
2012-09-27 9:51 ` [PATCH v2 2/2] omap3isp: Configure CSI-2 phy based on platform data Laurent Pinchart
2012-09-27 20:19 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5064B229.7010707@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).