From: Venu Byravarasu <vbyravarasu@nvidia.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: "rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] rtc: kconfig: fix RTC_INTF defaults connected to RTC_CLASS
Date: Wed, 10 Oct 2012 10:27:53 +0530 [thread overview]
Message-ID: <50750051.10701@nvidia.com> (raw)
In-Reply-To: <1349827784-8646-1-git-send-email-khilman@deeprootsystems.com>
On Wednesday 10 October 2012 05:39 AM, Kevin Hilman wrote:
> From: Kevin Hilman <khilman@ti.com>
>
> commit 6b8029fab64164b5895d58d23229b75c82e3a6fc (rtc: kconfig: remove
> unnecessary dependencies) removed various 'depends on RTC_CLASS'
> dependencies but also removed a few 'default RTC_CLASS' statements,
> which actually changed default behavior.
>
> This resulted in the various RTC interfaces (sysfs, proc, dev) all
> being disabled by default, even when RTC_CLASS is enabled:
>
> # CONFIG_RTC_INTF_SYSFS is not set
> # CONFIG_RTC_INTF_PROC is not set
> # CONFIG_RTC_INTF_DEV is not set
>
> which is different from previous behavior (all of these where enabled.)
>
> To fix, add back the 'default RTC_CLASS' statments to each of the
> RTC_INTF_* options.
Thanks for fixing this.
> config RTC_INTF_DEV
> boolean "/dev/rtcN (character devices)"
> + default RTC_CLASS
> help
> Say yes here if you want to use your RTCs using the /dev
> interfaces, which "udev" sets up as /dev/rtc0 through
Acked-by: Venu Byravarasu <vbyravarasu@nvidia.com>
prev parent reply other threads:[~2012-10-10 4:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 0:09 [PATCH] rtc: kconfig: fix RTC_INTF defaults connected to RTC_CLASS Kevin Hilman
2012-10-10 4:57 ` Venu Byravarasu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50750051.10701@nvidia.com \
--to=vbyravarasu@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).