From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH v2] arm/dts: AM33XX: Add SPI device tree data Date: Fri, 19 Oct 2012 10:24:15 +0200 Message-ID: <50810E2F.5@ti.com> References: <1347946228-25874-1-git-send-email-avinashphilip@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1347946228-25874-1-git-send-email-avinashphilip@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: "Philip, Avinash" Cc: linux@arm.linux.org.uk, tony@atomide.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, nsekhar@ti.com, gururaja.hebbar@ti.com List-Id: linux-omap@vger.kernel.org Hi Avinash, This look good to me except the: status = "disabled". The "disabled" should be reserved for variant that does not contain the IP. Is it the case here? Regards, Benoit On 09/18/2012 07:30 AM, Philip, Avinash wrote: > Add McSPI data node to AM33XX device tree file. The McSPI module (and so > as the driver) is reused from OMAP4. > > Signed-off-by: Philip, Avinash > Tested-by: Matt Porter > --- > Changes since v1: > - Corrected reg offset in reg DT entry. > > :100644 100644 ff3badb... 065fd54... M arch/arm/boot/dts/am33xx.dtsi > arch/arm/boot/dts/am33xx.dtsi | 25 +++++++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index ff3badb..065fd54 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -219,5 +219,30 @@ > interrupt-parent = <&intc>; > interrupts = <91>; > }; > + > + spi0: spi@48030000 { > + compatible = "ti,omap4-mcspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x48030000 0x400>; > + interrupt-parent = <&intc>; > + interrupt = <65>; > + ti,spi-num-cs = <2>; > + ti,hwmods = "spi0"; > + status = "disabled"; > + > + }; > + > + spi1: spi@481a0000 { > + compatible = "ti,omap4-mcspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x481a0000 0x400>; > + interrupt-parent = <&intc>; > + interrupt = <125>; > + ti,spi-num-cs = <2>; > + ti,hwmods = "spi1"; > + status = "disabled"; > + }; > }; > }; >