From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Ricardo Neri <ricardo.neri@ti.com>
Cc: s-guiriec@ti.com, peter.ujfalusi@ti.com, b-cousson@ti.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio
Date: Wed, 24 Oct 2012 07:29:19 +0300 [thread overview]
Message-ID: <50876E9F.5010305@ti.com> (raw)
In-Reply-To: <5086D200.7000008@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]
On 2012-10-23 20:21, Ricardo Neri wrote:
>> If so, you could pass only that one address, instead of the whole HDMI
>> register space?
> Yes, that could work. I thought about that but the common HDMI driver
> would have to know the the IP-specific register, which it should not.
Argh, of course...
> Perhaps the IP-specific register address can be passed by a IP-specific
> function such as hdmi_get_audio_dma_port for the common HDMI driver to
> populate the resource.
>
> Btw, could this be another reason to convert the IP-specific libraries
> to drivers?
Yes, I think it makes more and more sense to do that.
> Even though this would allow our HDMI drivers to be more inline with
> what other HDMI drivers do, things like power management and interrupts
> are still handled by DSS, unlike x86, for instance [1][2]. So the audio
> drivers will still depend on DSS. Also, the register layout is different
> for OMAP5 and audio registers are even more scattered. Furthermore, the
> common HDMI driver would have to know the IP-specific layout to know
> what register spaces expose to the audio driver (another reason to have
> IP-specific drivers?). So I would vote for continuing using the omapdss
> audio interface.
Okay.
I think your approach is ok for the time being. I don't like passing the
whole register space to the audio driver, but that's the best we can do
with the current driver.
Have you looked at converting to IP specific drivers? Any idea of the
effort? I'd like it to be done with the omap4 hdmi driver first, before
merging omap5 hdmi into the mainline, if at all possible.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]
next prev parent reply other threads:[~2012-10-24 4:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 1:27 [PATCH 0/6] Create platform device for audio support Ricardo Neri
2012-10-16 1:27 ` [PATCH 1/6] OMAPDSS: HDMI: Rename resource variable at probe Ricardo Neri
2012-10-16 1:27 ` [PATCH 2/6] OMAPDSS: Convert to devm_ioremap Ricardo Neri
2012-10-22 7:22 ` Tomi Valkeinen
2012-10-22 22:59 ` Ricardo Neri
2012-10-16 1:27 ` [PATCH 3/6] OMAPDSS: HDMI: Make panel return error if cannot register driver Ricardo Neri
2012-10-16 1:27 ` [PATCH 4/6] OMAPDSS: HDMI: Uninit display if unable to register device Ricardo Neri
2012-10-16 1:27 ` [PATCH 5/6] OMAPDSS: HDMI: Handle error when initing the display at probe Ricardo Neri
2012-10-16 1:27 ` [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio Ricardo Neri
2012-10-16 9:30 ` Péter Ujfalusi
2012-10-16 11:11 ` Ricardo Neri
2012-10-22 7:40 ` Tomi Valkeinen
2012-10-23 0:48 ` Ricardo Neri
2012-10-23 9:37 ` Tomi Valkeinen
2012-10-23 15:42 ` Ricardo Neri
2012-10-23 16:17 ` Tomi Valkeinen
2012-10-23 17:21 ` Ricardo Neri
2012-10-24 4:29 ` Tomi Valkeinen [this message]
2012-10-25 14:31 ` Ricardo Neri
2012-10-25 14:54 ` Tomi Valkeinen
2012-10-26 0:46 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50876E9F.5010305@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=ricardo.neri@ti.com \
--cc=s-guiriec@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).