From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: Build broken on linus/master? Date: Fri, 26 Oct 2012 15:51:57 +0530 Message-ID: <508A6445.5080303@ti.com> References: <508A50F0.2030308@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:46322 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755381Ab2JZKWK (ORCPT ); Fri, 26 Oct 2012 06:22:10 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Bedia, Vaibhav" Cc: "shuah.khan@hp.com" , "m.szyprowski@samsung.com" , Linux ARM Kernel List , Linux OMAP List , Russell King - ARM Linux On Friday 26 October 2012 03:32 PM, Bedia, Vaibhav wrote: > On Fri, Oct 26, 2012 at 14:29:28, Shilimkar, Santosh wrote: >> On Friday 26 October 2012 01:18 PM, Bedia, Vaibhav wrote: >>> Hi, >>> >>> Compiling the current linus/master (2ab3f29) using omap2plus_defconfig >>> throws up the following error >>> >>> $make -j7 uImage >>> CHK include/generated/uapi/linux/version.h >>> CHK include/generated/utsrelease.h >>> make[1]: `include/generated/mach-types.h' is up to date. >>> CC arch/arm/kernel/asm-offsets.s >>> In file included from include/linux/dma-mapping.h:76:0, >>> from arch/arm/kernel/asm-offsets.c:15: >>> /datalocal/kernel/arch/arm/include/asm/dma-mapping.h: In function 'dma_mapping_error': >>> /datalocal/kernel/arch/arm/include/asm/dma-mapping.h:94:2: error: implicit declaration of function 'debug_dma_mapping_error' >>> make[1]: *** [arch/arm/kernel/asm-offsets.s] Error 1 >>> make: *** [prepare0] Error 2 >>> >> Looks like it might break build on all ARM machines. I just >> noticed a patch adding debug_dma_mapping_error() for aarm64 arch. >> >> Marek, Shuah, >> Is kernel missing a patch which adds definition of >> debug_dma_mapping_error() to linux/dma-debug.h ? >> >> I can't seems to find this symbol in kernel grep. >> > > Just saw a pull request [1] from Marek asking Linus to revert the patch > which introduced this error. > Yep. I noticed that too. Just not sure whether Marek send the patch after seeing this email or he already seen the breakage. At least you would have got some reported-by credit it was former. :-) Anyways, the build break fix is on its way. Regards Santosh