From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@ti.com>,
Paul Walmsley <paul@pwsan.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 04/14] ARM: OMAP: Fix timer posted mode support
Date: Wed, 7 Nov 2012 16:21:07 -0600 [thread overview]
Message-ID: <509ADED3.1050901@ti.com> (raw)
In-Reply-To: <1352314890-22224-5-git-send-email-jon-hunter@ti.com>
On Wednesday 07 November 2012 01:01 PM, Jon Hunter wrote:
> Currently the dmtimer posted mode is being enabled when the function
> omap_dm_timer_enable_posted() is called. This function is only being called
> for OMAP1 timers and OMAP2+ timers that are being used as system timers. Hence,
> for OMAP2+ timers that are NOT being used as a system timer, posted mode is
> not enabled but the "timer->posted" variable is still set (incorrectly) in
> the omap_dm_timer_prepare() function.
>
> This is a regression introduced by commit 3392cdd3 (ARM: OMAP: dmtimer:
> switch-over to platform device driver) which was before the
> omap_dm_timer_enable_posted() function was introduced. Although this is a
> regression from the original code it only impacts performance and so is not
> needed for stable.
>
> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2012-11-07 22:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 19:01 [PATCH V2 00/14] ARM: OMAP: DMTIMER fixes Jon Hunter
2012-11-07 19:01 ` [PATCH V2 01/14] ARM: OMAP: Add DMTIMER definitions for posted mode Jon Hunter
2012-11-07 22:04 ` Santosh Shilimkar
2012-11-07 22:11 ` Jon Hunter
2012-11-07 22:18 ` Santosh Shilimkar
2012-11-07 22:47 ` Jon Hunter
2012-11-08 16:52 ` Jon Hunter
2012-11-07 19:01 ` [PATCH V2 02/14] ARM: OMAP2+: Disable posted mode for the clocksource timer Jon Hunter
2012-11-07 22:10 ` Santosh Shilimkar
2012-11-07 22:41 ` Jon Hunter
2012-11-07 19:01 ` [PATCH V2 03/14] ARM: OMAP3+: Implement timer workaround for errata i103 and i767 Jon Hunter
2012-11-07 22:14 ` Santosh Shilimkar
2012-11-07 23:28 ` Jon Hunter
2012-11-07 23:43 ` Santosh Shilimkar
2012-11-08 16:55 ` Jon Hunter
2012-11-09 19:41 ` Jon Hunter
2012-11-07 19:01 ` [PATCH V2 04/14] ARM: OMAP: Fix timer posted mode support Jon Hunter
2012-11-07 22:21 ` Santosh Shilimkar [this message]
2012-11-07 19:01 ` [PATCH V2 05/14] ARM: OMAP3: Correct HWMOD DMTIMER SYSC register declarations Jon Hunter
2012-11-07 19:01 ` [PATCH V2 06/14] ARM: OMAP2/3: Define HWMOD software reset status for DMTIMERs Jon Hunter
2012-11-07 19:01 ` [PATCH V2 07/14] ARM: OMAP2+: Don't use __omap_dm_timer_reset() Jon Hunter
2012-11-07 19:01 ` [PATCH V2 08/14] ARM: OMAP: Fix dmtimer reset for timer1 Jon Hunter
2012-11-07 19:01 ` [PATCH V2 09/14] ARM: OMAP: Don't restore of DMTIMER TISTAT register Jon Hunter
2012-11-07 19:01 ` [PATCH V2 10/14] ARM: OMAP: Don't restore DMTIMER interrupt status register Jon Hunter
2012-11-07 19:01 ` [PATCH V2 11/14] ARM: OMAP: Fix spurious interrupts when using timer match feature Jon Hunter
2012-11-07 19:01 ` [PATCH V2 12/14] ARM: OMAP: Add dmtimer interrupt disable function Jon Hunter
2012-11-07 19:01 ` [PATCH V2 13/14] ARM: OMAP: Remove unnecessary call to clk_get() Jon Hunter
2012-11-07 19:01 ` [PATCH V2 14/14] ARM: OMAP: Remove __omap_dm_timer_set_source function Jon Hunter
2012-11-07 21:22 ` [PATCH V2 00/14] ARM: OMAP: DMTIMER fixes Tony Lindgren
2012-11-07 21:44 ` Jon Hunter
2012-11-07 21:52 ` Tony Lindgren
2012-11-07 22:27 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509ADED3.1050901@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=jon-hunter@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).