From: Vaibhav Hiremath <hvaibhav@ti.com>
To: Mike Turquette <mturquette@ti.com>
Cc: paul@pwsan.com, rnayak@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@vger.kernel.org, patches@linaro.org,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH v2 00/26] Move OMAP2+ over to common clk framework
Date: Fri, 9 Nov 2012 00:34:52 +0530 [thread overview]
Message-ID: <509C0254.4080603@ti.com> (raw)
In-Reply-To: <1352337181-29427-1-git-send-email-mturquette@ti.com>
On 11/8/2012 6:42 AM, Mike Turquette wrote:
> From: Mike Turquette <mturquette@linaro.org>
>
> Hi all,
>
> This series is based on top of Paul's PRM/CM clean-up work. It is a
> refresh of the patches Rajendra sent out a while back[1], with the
> addition of several fixes for PM regressions[2] across several
> platforms.
>
> I have tested on OMAP4430 Panda including PRCM diffing against pre-CCF
> patches (delta is zero) and also suspend/resume.
>
> I also tested on OMAP4460 Panda-ES. Boot is fine and PRCM programming
> appears sane. However Panda-ES never comes back from suspend/resume.
> This problem exists on the PRM/CM branch I based on and was not
> introduced by this series. I am investigating that independently of
> this series.
>
> Anyone wanting to pull the work can find it at:
> git://git.linaro.org/people/mturquette/linux.git clk-omap-3.8
>
> [1] http://article.gmane.org/gmane.linux.ports.arm.omap/78771
> [2] http://article.gmane.org/gmane.linux.ports.arm.omap/84015
>
> Mike Turquette (3):
> ARM: OMAP4: clock: Convert to common clk
> ARM: OMAP2+: clock: remove unnecessary declarations
> ARM: OMAP2+: clock: Cleanup !CONFIG_COMMON_CLK parts
>
> Paul Walmsley (7):
> ARM: OMAP2xxx: clock: add APLL rate recalculation functions
> ARM: OMAP2+: clock: add OMAP CCF convenience macros to
> mach-omap2/clock.h
> ARM: AM33XX: clock: add clock data in common clock format
> ARM: OMAP44xx: clock: drop obsolete clock data
> ARM: OMAP3xxx: clk: drop obsolete clock data
> ARM: AM33xx: clock: drop obsolete clock data
> ARM: OMAP2xxx: clock: drop obsolete clock data
>
> Rajendra Nayak (15):
> ARM: OMAP: clock: Nuke plat/clock.c & reuse struct clk as clk_hw_omap
> ARM: OMAP: hwmod: Fix up hwmod based clkdm accesses
> ARM: OMAP3: clock: Convert to common clk
> ARM: OMAP2: clock: Convert to common clk
> ARM: OMAP: clock: list all clk_hw_omap clks to enable/disable
> autoidle
> ARM: OMAP: clock: Define a function to enable clocks at init
> ARM: OMAP: clock: Get rid of some clkdm assocations within clks
> ARM: OMAP4: clock: Add 44xx data using common struct clk
> ARM: OMAP3: clock: Add 3xxx data using common struct clk
> ARM: omap2: clock: Add 24xx data using common struct clk
> ARM: OMAP: clock: Switch to COMMON clk
> ARM: OMAP: hwmod: Cleanup !CONFIG_COMMON_CLK parts
> ARM: OMAP4: clock: Cleanup !CONFIG_COMMON_CLK parts
> ARM: omap3: clock: Cleanup !CONFIG_COMMON_CLK parts
> ARM: omap2: clock: Cleanup !CONFIG_COMMON_CLK parts
>
> Vaibhav Hiremath (1):
> ARM: OMAP2+: hwmod: Invoke init_clkdm before other init functions
>
> arch/arm/mach-omap2/Kconfig | 5 +
> arch/arm/mach-omap2/Makefile | 10 +-
> arch/arm/mach-omap2/cclock2420_data.c | 1959 ++++++++++++++
> arch/arm/mach-omap2/cclock2430_data.c | 2073 +++++++++++++++
> arch/arm/mach-omap2/cclock33xx_data.c | 961 +++++++
> arch/arm/mach-omap2/cclock3xxx_data.c | 3595 +++++++++++++++++++++++++
> arch/arm/mach-omap2/cclock44xx_data.c | 1991 ++++++++++++++
> arch/arm/mach-omap2/clkt2xxx_apll.c | 66 +-
> arch/arm/mach-omap2/clkt2xxx_dpll.c | 8 +-
> arch/arm/mach-omap2/clkt2xxx_dpllcore.c | 12 +-
> arch/arm/mach-omap2/clkt2xxx_osc.c | 13 +-
> arch/arm/mach-omap2/clkt2xxx_sys.c | 7 +-
> arch/arm/mach-omap2/clkt2xxx_virt_prcm_set.c | 11 +-
> arch/arm/mach-omap2/clkt34xx_dpll3m2.c | 8 +-
> arch/arm/mach-omap2/clkt_clksel.c | 194 +-
> arch/arm/mach-omap2/clkt_dpll.c | 28 +-
> arch/arm/mach-omap2/clkt_iclk.c | 31 +-
> arch/arm/mach-omap2/clock.c | 845 ++----
> arch/arm/mach-omap2/clock.h | 356 ++-
> arch/arm/mach-omap2/clock2420_data.c | 1986 --------------
> arch/arm/mach-omap2/clock2430.c | 8 +-
> arch/arm/mach-omap2/clock2430_data.c | 2085 ---------------
> arch/arm/mach-omap2/clock2xxx.c | 1 +
> arch/arm/mach-omap2/clock2xxx.h | 47 +-
> arch/arm/mach-omap2/clock33xx_data.c | 1107 --------
> arch/arm/mach-omap2/clock34xx.c | 51 +-
> arch/arm/mach-omap2/clock3517.c | 24 +-
> arch/arm/mach-omap2/clock36xx.c | 22 +-
> arch/arm/mach-omap2/clock36xx.h | 2 +-
> arch/arm/mach-omap2/clock3xxx.c | 6 +-
> arch/arm/mach-omap2/clock3xxx.h | 6 +-
> arch/arm/mach-omap2/clock3xxx_data.c | 3613 --------------------------
> arch/arm/mach-omap2/clock44xx_data.c | 3398 ------------------------
> arch/arm/mach-omap2/clock_common_data.c | 22 +-
> arch/arm/mach-omap2/cm-regbits-24xx.h | 5 +
> arch/arm/mach-omap2/cm-regbits-34xx.h | 31 +
> arch/arm/mach-omap2/cm2xxx_3xxx.h | 1 +
> arch/arm/mach-omap2/dpll3xxx.c | 226 +-
> arch/arm/mach-omap2/dpll44xx.c | 21 +-
> arch/arm/mach-omap2/io.c | 25 +
> arch/arm/mach-omap2/omap_hwmod.c | 63 +-
> arch/arm/mach-omap2/pm24xx.c | 4 +-
> arch/arm/mach-omap2/prm-regbits-24xx.h | 2 +
> arch/arm/mach-omap2/prm-regbits-34xx.h | 1 +
> arch/arm/mach-omap2/prm2xxx_3xxx.h | 1 +
> arch/arm/mach-omap2/scrm44xx.h | 2 +
> 46 files changed, 11539 insertions(+), 13394 deletions(-)
> create mode 100644 arch/arm/mach-omap2/cclock2420_data.c
> create mode 100644 arch/arm/mach-omap2/cclock2430_data.c
> create mode 100644 arch/arm/mach-omap2/cclock33xx_data.c
> create mode 100644 arch/arm/mach-omap2/cclock3xxx_data.c
> create mode 100644 arch/arm/mach-omap2/cclock44xx_data.c
> delete mode 100644 arch/arm/mach-omap2/clock2420_data.c
> delete mode 100644 arch/arm/mach-omap2/clock2430_data.c
> delete mode 100644 arch/arm/mach-omap2/clock33xx_data.c
> delete mode 100644 arch/arm/mach-omap2/clock3xxx_data.c
> delete mode 100644 arch/arm/mach-omap2/clock44xx_data.c
>
Thanks Mike for the patches.
Just boot tested it on BeagleBone Platform, and it is booting up fine
for me without any issues. Also I did some basic clk_rate check, and it
came out well.
Anyway, I will try to review it tomorrow (if time permits).
Thanks,
Vaibhav
next prev parent reply other threads:[~2012-11-08 19:04 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 1:12 [PATCH v2 00/26] Move OMAP2+ over to common clk framework Mike Turquette
2012-11-08 1:12 ` [PATCH 01/26] ARM: OMAP: clock: Nuke plat/clock.c & reuse struct clk as clk_hw_omap Mike Turquette
2012-11-08 1:12 ` [PATCH 02/26] ARM: OMAP: hwmod: Fix up hwmod based clkdm accesses Mike Turquette
2012-11-12 22:15 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 03/26] ARM: OMAP4: clock: Convert to common clk Mike Turquette
2012-11-12 22:52 ` Paul Walmsley
2012-11-13 2:17 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 04/26] ARM: OMAP3: " Mike Turquette
2012-11-08 1:12 ` [PATCH 05/26] ARM: OMAP2: " Mike Turquette
2012-11-12 22:16 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 06/26] ARM: OMAP2xxx: clock: add APLL rate recalculation functions Mike Turquette
2012-11-08 1:12 ` [PATCH 07/26] ARM: OMAP: clock: list all clk_hw_omap clks to enable/disable autoidle Mike Turquette
2012-11-12 23:00 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 08/26] ARM: OMAP: clock: Define a function to enable clocks at init Mike Turquette
2012-11-12 23:01 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 09/26] ARM: OMAP2+: hwmod: Invoke init_clkdm before other init functions Mike Turquette
2012-11-08 1:12 ` [PATCH 10/26] ARM: OMAP: clock: Get rid of some clkdm assocations within clks Mike Turquette
2012-11-08 1:12 ` [PATCH 11/26] ARM: OMAP2+: clock: add OMAP CCF convenience macros to mach-omap2/clock.h Mike Turquette
2012-11-08 1:12 ` [PATCH 12/26] ARM: OMAP4: clock: Add 44xx data using common struct clk Mike Turquette
2012-11-13 1:37 ` Paul Walmsley
2012-11-13 2:16 ` Paul Walmsley
2012-11-08 1:12 ` [PATCH 13/26] ARM: AM33XX: clock: add clock data in common clock format Mike Turquette
2012-11-08 1:12 ` [PATCH 16/26] ARM: OMAP: clock: Switch to COMMON clk Mike Turquette
2012-11-08 1:12 ` [PATCH 17/26] ARM: OMAP: hwmod: Cleanup !CONFIG_COMMON_CLK parts Mike Turquette
2012-11-08 1:12 ` [PATCH 18/26] ARM: OMAP4: clock: " Mike Turquette
2012-11-08 1:12 ` [PATCH 20/26] ARM: omap3: " Mike Turquette
2012-11-08 1:12 ` [PATCH 22/26] ARM: AM33xx: clock: drop obsolete clock data Mike Turquette
2012-11-08 1:12 ` [PATCH 23/26] ARM: omap2: clock: Cleanup !CONFIG_COMMON_CLK parts Mike Turquette
2012-11-08 1:13 ` [PATCH 25/26] ARM: OMAP2+: clock: remove unnecessary declarations Mike Turquette
2012-11-08 1:13 ` [PATCH 26/26] ARM: OMAP2+: clock: Cleanup !CONFIG_COMMON_CLK parts Mike Turquette
2012-11-08 1:31 ` [PATCH v2 00/26] Move OMAP2+ over to common clk framework Mike Turquette
2012-11-08 1:42 ` Tony Lindgren
2012-11-08 1:54 ` Mike Turquette
2012-11-08 2:50 ` Paul Walmsley
2012-11-08 5:02 ` Rajendra Nayak
2012-11-08 5:19 ` Mike Turquette
2012-11-08 19:20 ` Kevin Hilman
[not found] ` <1352337181-29427-15-git-send-email-mturquette@ti.com>
2012-11-08 18:08 ` [PATCH 14/26] ARM: OMAP3: clock: Add 3xxx data using common struct clk Paul Walmsley
2012-11-08 21:52 ` Mike Turquette
2012-11-08 22:01 ` Paul Walmsley
2012-11-09 0:11 ` Paul Walmsley
2012-11-09 0:33 ` Paul Walmsley
2012-11-09 0:49 ` Paul Walmsley
2012-11-09 0:57 ` Mike Turquette
2012-11-08 23:31 ` [PATCH] ARM: OMAP2+: clockdomain: disabling unused clks Mike Turquette
2012-11-09 0:58 ` Paul Walmsley
2012-11-09 1:17 ` Mike Turquette
2012-11-09 19:06 ` Paul Walmsley
2012-11-09 19:08 ` Paul Walmsley
2012-11-09 19:40 ` Mike Turquette
2012-11-09 19:52 ` Paul Walmsley
2012-11-09 20:53 ` Paul Walmsley
2012-11-08 19:04 ` Vaibhav Hiremath [this message]
2012-11-09 21:12 ` [PATCH v2 00/26] Move OMAP2+ over to common clk framework Paul Walmsley
2012-11-09 22:09 ` Tony Lindgren
2012-11-09 22:18 ` Mike Turquette
2012-11-09 23:47 ` Paul Walmsley
2012-11-12 21:50 ` [PATCH] ARM: OMAP3+: DPLL: drop !CONFIG_COMMON_CLK sections Paul Walmsley
2012-11-12 22:30 ` Mike Turquette
[not found] ` <1352337181-29427-16-git-send-email-mturquette@ti.com>
[not found] ` <alpine.DEB.2.00.1211081532210.20703@utopia.booyaka.com>
2012-11-09 20:32 ` [PATCH 15/26] ARM: omap2: clock: Add 24xx data using common struct clk Paul Walmsley
2012-11-09 21:05 ` Mike Turquette
2012-11-09 21:22 ` Paul Walmsley
2012-11-09 22:21 ` Mike Turquette
2012-11-12 22:13 ` Paul Walmsley
2012-11-13 13:42 ` [PATCH v2 00/26] Move OMAP2+ over to common clk framework Laurent Pinchart
2012-11-13 16:43 ` Mike Turquette
2012-11-15 0:57 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509C0254.4080603@ti.com \
--to=hvaibhav@ti.com \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=mturquette@ti.com \
--cc=patches@linaro.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).