Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Ricardo Neri <ricardo.neri@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: lrg@ti.com, s-guiriec@ti.com, linux-omap@vger.kernel.org,
	alsa-devel@alsa-project.org, "Valkeinen,
	Tomi" <tomi.valkeinen@ti.com>
Subject: Re: [PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources
Date: Wed, 14 Nov 2012 11:07:09 -0600	[thread overview]
Message-ID: <50A3CFBD.5080903@ti.com> (raw)
In-Reply-To: <20121114032712.GQ4415@opensource.wolfsonmicro.com>

Hi Mark,

Thanks for reviewing!				

On 11/13/2012 09:27 PM, Mark Brown wrote:
> On Tue, Nov 13, 2012 at 08:30:49PM -0600, Ricardo Neri wrote:
>> Instead of defining the address offset of the DMA port for transfers of
>> audio samples, obtain this information from the resources of the device.
>> This device and its resources are created by the OMAPDSS HDMI driver.
>
> Presumably this needs some other corresponding change in the resource
> setup to go in simultaneously...

Yes, the change in the resources setup has been submitted to the OMAPDSS 
HDMI driver and accepted by Tomi [1].

>
>> -	hdmi_data->dma_params.port_addr =  hdmi_rsrc->start
>> -		+ OMAP_HDMI_AUDIO_DMA_PORT;
>> +	hdmi_data->dma_params.port_addr =  hdmi_rsrc->start;
>
> ...both before and after versions use the resource.

This change should be present in K3.8.
>

BR,

Ricardo

[1].http://www.mail-archive.com/linux-omap@vger.kernel.org/msg79801.html

  reply	other threads:[~2012-11-14 17:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14  2:30 [PATCH 0/3] Updated names for ASoC OMAP HDMI drivers Ricardo Neri
2012-11-14  2:30 ` [PATCH 1/3] ASoC: OMAP: HDMI: Update machine driver name Ricardo Neri
2012-11-14 10:16   ` Liam Girdwood
2012-11-14 17:00     ` Ricardo Neri
2012-11-14  2:30 ` [PATCH 2/3] ASoC: OMAP: HDMI: Update CPU DAI " Ricardo Neri
2012-11-14  2:30 ` [PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources Ricardo Neri
2012-11-14  3:27   ` Mark Brown
2012-11-14 17:07     ` Ricardo Neri [this message]
2012-11-14 23:08       ` Mark Brown
2012-11-15  2:33         ` Ricardo Neri
2012-11-15  4:10           ` Mark Brown
2012-11-15 16:22             ` Ricardo Neri
2012-11-15  9:45           ` Tomi Valkeinen
2012-11-15 12:36             ` Tomi Valkeinen
2012-11-16  1:39               ` Ricardo Neri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A3CFBD.5080903@ti.com \
    --to=ricardo.neri@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=s-guiriec@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox