Re: [PATCH] omap2/ompafb/omapfb-main.c: Delete if evaluating constant.

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

On 2012-11-16 19:51, Matthias Brugger wrote:
> Variable r is never set to any value different to zero.
> Delete the if statement as it will never executed.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>  drivers/video/omap2/omapfb/omapfb-main.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
> index 16db158..85f9de0 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -2411,7 +2411,6 @@ static int __init omapfb_probe(struct platform_device *pdev)
>  	fbdev->dev = &pdev->dev;
>  	platform_set_drvdata(pdev, fbdev);
>  
> -	r = 0;
>  	fbdev->num_displays = 0;
>  	dssdev = NULL;
>  	for_each_dss_dev(dssdev) {
> @@ -2434,9 +2433,6 @@ static int __init omapfb_probe(struct platform_device *pdev)
>  			d->update_mode = OMAPFB_AUTO_UPDATE;
>  	}
>  
> -	if (r)
> -		goto cleanup;
> -
>  	if (fbdev->num_displays == 0) {
>  		dev_err(&pdev->dev, "no displays\n");
>  		r = -EINVAL;
> 

Thanks, I'll apply to omapdss tree.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 897 bytes --]