From: Archit Taneja <archit@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: t-kristo@ti.com, Rajendra Nayak <rnayak@ti.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: OMAP4430 produces boot warnings
Date: Wed, 28 Nov 2012 16:14:58 +0530 [thread overview]
Message-ID: <50B5EB2A.3040204@ti.com> (raw)
In-Reply-To: <1354019506.3250.10.camel@sokoban>
On Tuesday 27 November 2012 06:01 PM, Tero Kristo wrote:
> On Tue, 2012-11-27 at 14:21 +0200, Tomi Valkeinen wrote:
>> On 2012-11-27 13:56, Archit Taneja wrote:
>>> On Tuesday 27 November 2012 04:53 PM, Tomi Valkeinen wrote:
>>
>>>> Hmm, well this feels like a hack. DISPC driver doesn't know how the DSS
>>>> modules are arranged, which module belongs to which power domain, etc.
>>>>
>>>> If it cannot be fixed in the arch code, I guess we could just have
>>>> dss_get_ctx_loss_count(void) function which always returns the
>>>> dss_core's ctx loss count, and define that on all the platforms omapdss
>>>> is used, the dss_core's ctx loss count is the same as ctx loss count for
>>>> all the dss submodules.
Well the context lost count we are interested in isn't the "omapdss"
platform device in core.c, it's the "omapdss_dss" platform device in dss.c
I was considering moving the dss_get_ctx_lost_count() to dss.c, as it
needs the "omapdss_dss" platform_device. It looks better in core.c, but
we would need a dirty way to give it the "omapdss_dss". What do you think?
Archit
>>>>
>>>> I think the above is true for all OMAPs. But it feels like a hack too,
>>>> but not as bad as the above patch.
>>>
>>> Yes, a function taking in no platform device in dss's core.c would be
>>> less hacky. I guess we would need this for now, because a solution in
>>> omap_hwmod would be more complex and it may not be ready by the merge
>>> window.
>>
>> Ok. Can you cook up a patch and test it?
>>
>> PM guys, does the above sound like an acceptable work-around?
>
> This sounds like a good approach to me at least.
>
> -Tero
>
>
>
>
prev parent reply other threads:[~2012-11-28 10:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 23:03 OMAP4430 produces boot warnings Russell King - ARM Linux
2012-11-22 12:42 ` Archit Taneja
2012-11-22 13:42 ` Tomi Valkeinen
2012-11-22 14:34 ` Tero Kristo
2012-11-22 14:44 ` Tomi Valkeinen
2012-11-23 9:34 ` Tero Kristo
2012-11-26 6:48 ` Archit Taneja
2012-11-26 12:14 ` Archit Taneja
2012-11-27 11:23 ` Tomi Valkeinen
2012-11-27 11:56 ` Archit Taneja
2012-11-27 12:21 ` Tomi Valkeinen
2012-11-27 12:31 ` Tero Kristo
2012-11-28 10:44 ` Archit Taneja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B5EB2A.3040204@ti.com \
--to=archit@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).