From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: NeilBrown <neilb@suse.de>
Cc: Chandrabhanu Mahapatra <cmahapatra@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list
Date: Mon, 17 Dec 2012 13:58:59 +0200 [thread overview]
Message-ID: <50CF0903.8010205@ti.com> (raw)
In-Reply-To: <20121216080803.618a3634@notabene.brown>
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
On 2012-12-15 23:08, NeilBrown wrote:
>
> commit 195e672a76056478cc79f5c48343164c9237852e
> OMAPDSS: DPI: Remove cpu_is_xxxx checks
>
> made the mistake of assuming that cpu_is_omap34xx() is exclusive of
> other cpu_is_* predicates whereas it includes cpu_is_omap3630().
>
> So on an omap3630, code that was previously enabled by
> if (cpu_is_omap34xx())
> is now disabled as
> dss_has_feature(FEAT_DPI_USES_VDDS_DSI)
> fails.
>
> So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list.
>
> Cc: Chandrabhanu Mahapatra <cmahapatra@ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: NeilBrown <neilb@suse.de>
>
> diff --git a/drivers/video/omap2/dss/dss_features.c b/drivers/video/omap2/dss/dss_features.c
> index acbc1e1..aaf3c3f 100644
> --- a/drivers/video/omap2/dss/dss_features.c
> +++ b/drivers/video/omap2/dss/dss_features.c
> @@ -546,6 +546,7 @@ static const enum dss_feat_id omap3630_dss_feat_list[] = {
> FEAT_ALPHA_FIXED_ZORDER,
> FEAT_FIFO_MERGE,
> FEAT_OMAP3_DSI_FIFO_BUG,
> + FEAT_DPI_USES_VDDS_DSI,
> };
>
> static const enum dss_feat_id omap4430_es1_0_dss_feat_list[] = {
>
Thanks, looks correct. Did you encounter a bug related to this, or just
happened to notice?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
next prev parent reply other threads:[~2012-12-17 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 21:08 [PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list NeilBrown
2012-12-17 11:58 ` Tomi Valkeinen [this message]
2012-12-17 20:27 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CF0903.8010205@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=cmahapatra@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).