From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [PATCH v2 3/3] gpio: twl4030: TODO comment to remove the PWMA/B (LEDA/B) handling Date: Thu, 20 Dec 2012 10:23:39 +0100 Message-ID: <50D2D91B.8010203@ti.com> References: <1354791127-20545-1-git-send-email-peter.ujfalusi@ti.com> <1354791127-20545-4-git-send-email-peter.ujfalusi@ti.com> <20121219170737.E5DB13E0C56@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:34369 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646Ab2LTJXo (ORCPT ); Thu, 20 Dec 2012 04:23:44 -0500 In-Reply-To: <20121219170737.E5DB13E0C56@localhost> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Grant Likely Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org On 12/19/2012 06:07 PM, Grant Likely wrote: > On Thu, 6 Dec 2012 11:52:07 +0100, Peter Ujfalusi wrote: >> This GPIO driver should not configure anything else then GPIOs. >> >> Signed-off-by: Peter Ujfalusi >=20 > I'm not sure if this is the right direction. I actually have no probl= em > with a single driver that registers itself with multiple interfaces (= ie. > GPIO and PWM) if it makes sense for it to do so. I suspec that a lot = of > the multifunction device drivers break things up more than is strictl= y > necessary. We have PWM drivers for these IPs. As you remember this is the reason I started to work on the gpio-pwm driver so we can have cleaner, more gen= eric way to map a PWM as a gpio. I really don't like the idea of having the = same PWM code sitting in various places in the kernel just because it was ea= sier to hack it like that rather then to make an effort for a clean implementat= ion. The PWM handling in the gpio-twl4030 driver is a prime example of this = IMHO. It is just a shortcut, nothing else. > I'll still apply this if you think it is the right direction, but I > wanted to throw that though out there for consideration. --=20 P=E9ter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html