From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
linux-omap@vger.kernel.org, David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Cyril Chemparathy <cyril@ti.com>
Subject: Re: [PATCH 2/2] cpts: fix a run time warn_on.
Date: Sun, 23 Dec 2012 18:07:22 +0400 [thread overview]
Message-ID: <50D7101A.6020506@mvista.com> (raw)
In-Reply-To: <ad26ca328f0eba6a722d0288ac1c37ad55789447.1356204860.git.richardcochran@gmail.com>
Hello.
On 22-12-2012 23:41, Richard Cochran wrote:
> This patch fixes a warning in clk_enable by calling clk_prepare first.
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> ---
> drivers/net/ethernet/ti/cpts.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
> index 5ab8fb4..3e32a31 100644
> --- a/drivers/net/ethernet/ti/cpts.c
> +++ b/drivers/net/ethernet/ti/cpts.c
> @@ -247,6 +247,7 @@ static void cpts_clk_init(struct cpts *cpts)
> cpts->refclk = NULL;
> return;
> }
> + clk_prepare(cpts->refclk);
> clk_enable(cpts->refclk);
Maybe just call clk_prepare_enable() instead?
WBR, Sergei
next prev parent reply other threads:[~2012-12-23 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 19:41 [PATCH 0/2] cpts fixes for v3.8-rc2 Richard Cochran
2012-12-22 19:41 ` [PATCH 1/2] cpts: fix build error by removing useless code Richard Cochran
2012-12-22 19:41 ` [PATCH 2/2] cpts: fix a run time warn_on Richard Cochran
2012-12-23 14:07 ` Sergei Shtylyov [this message]
2012-12-24 6:46 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D7101A.6020506@mvista.com \
--to=sshtylyov@mvista.com \
--cc=cyril@ti.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).