From mboxrd@z Thu Jan 1 00:00:00 1970 From: R Sricharan Subject: Re: [PATCH 1/1] arm :omap :DMA: fix a bug on reserving the omap SDMA channels Date: Thu, 3 Jan 2013 12:58:11 +0530 Message-ID: <50E5330B.2060007@ti.com> References: <1356813800-4705-1-git-send-email-ahemaily@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1356813800-4705-1-git-send-email-ahemaily@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: ahemaily@gmail.com Cc: tony@atomide.com, linux-omap@vger.kernel.org, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Hi, On Sunday 30 December 2012 02:13 AM, ahemaily@gmail.com wrote: > From: ahemaily > > The variable dma_lch_count used for comparison (omap_dma_reserve_channels <= dma_lch_count) > before it initialized to the value from omap_dma_dev_attr : d->lch_count. > > I change the place of dma_lch_count initialization to be before the comparison. > > Signed-off-by: Abdelrahman Hemaily > --- > arch/arm/plat-omap/dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c > index c76ed8b..cb3e321 100644 > --- a/arch/arm/plat-omap/dma.c > +++ b/arch/arm/plat-omap/dma.c > @@ -2014,12 +2014,12 @@ static int __devinit omap_system_dma_probe(struct platform_device *pdev) > > d = p->dma_attr; > errata = p->errata; > - > + dma_lch_count = d->lch_count; > + > if ((d->dev_caps & RESERVE_CHANNEL) && omap_dma_reserve_channels > && (omap_dma_reserve_channels <= dma_lch_count)) > d->lch_count = omap_dma_reserve_channels; > > - dma_lch_count = d->lch_count; By removing this line, you are effectively not assigning d->lch_count after reserving. So the patch should only change dma_lch_count in the above "if statement" to d->lch_count Regards, Sricharan