From: Roger Quadros <rogerq@ti.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: sameo@linux.intel.com, tony@atomide.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@ti.com, keshava_mgowda@ti.com,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
bjorn@mork.no
Subject: Re: [PATCH v5 13/22] mfd: omap-usb-host: override number of ports from platform data
Date: Fri, 4 Jan 2013 16:06:53 +0200 [thread overview]
Message-ID: <50E6E1FD.40604@ti.com> (raw)
In-Reply-To: <50E57F10.6030402@mvista.com>
On 01/03/2013 02:52 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 02-01-2013 19:00, Roger Quadros wrote:
>
>> Both OMAP4 and 5 exhibit the same revision ID in the REVISION register
>> but they have different number of ports i.e. 2 and 3 respectively.
>> So we can't rely on REVISION register for number of ports on OMAP5
>> and depend on platform data (or device tree) instead.
>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> [...]
>
>> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
>> index 5edb828..710460d 100644
>> --- a/drivers/mfd/omap-usb-host.c
>> +++ b/drivers/mfd/omap-usb-host.c
>> @@ -497,19 +497,27 @@ static int usbhs_omap_probe(struct
>> platform_device *pdev)
>> */
>> pm_runtime_put_sync(dev);
>>
>> - switch (omap->usbhs_rev) {
>> - case OMAP_USBHS_REV1:
>> - omap->nports = 3;
>> - break;
>> - case OMAP_USBHS_REV2:
>> - omap->nports = 2;
>> - break;
>> - default:
>> - omap->nports = OMAP3_HS_USB_PORTS;
>> - dev_dbg(dev,
>> - "USB HOST Rev : 0x%d not recognized, assuming %d ports\n",
>> - omap->usbhs_rev, omap->nports);
>> - break;
>> + /*
>> + * If platform data contains nports then use that
>> + * else make out number of ports from USBHS revision
>> + */
>> + if (pdata->nports) {
>> + omap->nports = pdata->nports;
>> + } else {
>> + switch (omap->usbhs_rev) {
>> + case OMAP_USBHS_REV1:
>> + omap->nports = 3;
>> + break;
>> + case OMAP_USBHS_REV2:
>> + omap->nports = 2;
>> + break;
>> + default:
>> + omap->nports = OMAP3_HS_USB_PORTS;
>> + dev_dbg(dev,
>> + "USB HOST Rev:0x%d not recognized, assuming %d ports\n",
>
> Please indent the string to the right somewhat, as it was before.
>
OK. I will fix it in the pull request e-mail that i'll send in a while
as a reply to the first message in this patchset.
--
cheers,
-roger
next prev parent reply other threads:[~2013-01-04 14:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 15:00 [PATCH v5 00/22] OMAP USB Host cleanup Roger Quadros
2013-01-02 15:00 ` [PATCH v5 01/22] mfd: omap-usb-tll: Avoid creating copy of platform data Roger Quadros
2013-01-02 15:00 ` [PATCH v5 02/22] mfd: omap-usb-tll: Fix channel count detection Roger Quadros
2013-01-02 15:00 ` [PATCH v5 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path Roger Quadros
2013-01-02 15:00 ` [PATCH v5 04/22] mfd: omap-usb-tll: Clean up clock handling Roger Quadros
2013-01-02 15:00 ` [PATCH v5 05/22] mfd: omap-usb-tll: introduce and use mode_needs_tll() Roger Quadros
2013-01-02 15:00 ` [PATCH v5 06/22] mfd: omap-usb-tll: Check for missing platform data in probe Roger Quadros
[not found] ` <1357138842-28964-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-01-02 15:00 ` [PATCH v5 07/22] mfd: omap-usb-tll: Fix error message Roger Quadros
2013-01-02 15:00 ` [PATCH v5 08/22] mfd: omap-usb-tll: serialize access to TLL device Roger Quadros
2013-01-02 15:00 ` [PATCH v5 09/22] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support Roger Quadros
2013-01-02 15:00 ` [PATCH v5 10/22] mfd: omap_usb_host: Avoid creating copy of platform_data Roger Quadros
2013-01-02 15:00 ` [PATCH v5 11/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap() Roger Quadros
2013-01-02 15:00 ` [PATCH v5 12/22] mfd: omap-usb-host: know about number of ports from revision register Roger Quadros
2013-01-02 15:00 ` [PATCH v5 13/22] mfd: omap-usb-host: override number of ports from platform data Roger Quadros
[not found] ` <1357138842-28964-14-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-01-03 12:52 ` Sergei Shtylyov
2013-01-04 14:06 ` Roger Quadros [this message]
2013-01-02 15:00 ` [PATCH v5 14/22] mfd: omap-usb-host: cleanup clock management code Roger Quadros
2013-01-02 15:00 ` [PATCH v5 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode Roger Quadros
2013-01-02 15:00 ` [PATCH v5 16/22] mfd: omap-usb-host: Get rid of unnecessary spinlock Roger Quadros
2013-01-02 15:00 ` [PATCH v5 17/22] mfd: omap-usb-host: clean up omap_usbhs_init() Roger Quadros
2013-01-02 15:00 ` [PATCH v5 18/22] USB: ehci-omap: Don't free gpios that we didn't request Roger Quadros
2013-01-02 15:00 ` [PATCH v5 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies Roger Quadros
2013-01-02 15:00 ` [PATCH v5 20/22] ARM: OMAP4: clock data: get rid of unused USB host clock aliases Roger Quadros
2013-01-02 15:00 ` [PATCH v5 21/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure Roger Quadros
2013-01-02 15:00 ` [PATCH v5 22/22] mdf: omap-usb-host: get rid of build warning Roger Quadros
2013-01-04 14:17 ` [PATCH v5 00/22] OMAP USB Host cleanup Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E6E1FD.40604@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=bjorn@mork.no \
--cc=keshava_mgowda@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sshtylyov@mvista.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).