linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jack Mitchell <ml@communistcode.co.uk>
To: ml@communistcode.co.uk
Cc: "Jan Lübbe" <jlu@pengutronix.de>,
	"Ben Gamari" <bgamari.foss@gmail.com>,
	balbi@ti.com, linux-omap@vger.kernel.org, mporter@ti.com
Subject: Re: AM335x BeagleBone SPI Issues
Date: Fri, 04 Jan 2013 16:36:15 +0000	[thread overview]
Message-ID: <50E704FF.107@communistcode.co.uk> (raw)
In-Reply-To: <50E7019E.5090109@communistcode.co.uk>

On 04/01/13 16:21, Jack Mitchell wrote:
> On 04/01/13 14:46, Jan Lübbe wrote:
>> Hi,
>>
>> On Tue, 2012-12-11 at 17:02 +0000, Jack Mitchell wrote:
>>> On 11/12/12 16:24, Jack Mitchell wrote:
>>>> On 11/12/12 15:22, Ben Gamari wrote:
>>>>> Jack Mitchell <ml@communistcode.co.uk> writes:
>>>>>> Thank you, the reordering dma patch fixed the dma issue I was 
>>>>>> having!
>>>>>> However, the bad news, I now get the same results for the dma and
>>>>>> non-dma spidev test. While the scope shows the SPI clk and data is
>>>>>> fine,
>>>>>> the reading from the program still shows 0x00 for all words.
>>>>>>
>>>>> Just to make sure this has been thought of: I've seen this sort of
>>>>> behavior in the past when the CLK pin wasn't configured as an input.
>> *snip*
>>
>>> My bad! The jumper bridge had come loose, it works now! Yippee!
>>>
>>> root@beaglebone:~# ./spidev -D /dev/spidev2.0
>>> spi mode: 0
>>> bits per word: 16
>>> max speed: 24000000 Hz (24000 KHz)
>>>
>>> FF FF FF FF FF FF
>>> 40 00 00 00 00 95
>>> FF FF FF FF FF FF
>>> FF FF FF FF FF FF
>>> FF FF FF FF FF FF
>>> DE AD BE EF BA AD
>>> F0 0D
>>> root@beaglebone:~#
>>>
>>> Thanks everyone, and do I need to submit any patches to clear this 
>>> all up?
>>>
>>> Currently all I see is changing the clk pins from output to input (if
>>> this is a valid change?).
>> I just stumbled over the same problem and have not seen any patch for
>> this fix. Have I missed something or should I send a patch? Which would
>> be the correct base for such a patch?
>>
>> Regards,
>> Jan
>
> I didn't submit a patch for this but easily could. I was confused 
> about what tree to base it against as at the time (may still be the 
> same) DT SPI for AM335x was not in a mainline tree. I hoped someone 
> would pick it up when posting DT SPI for mainline....
>

I've just had confirmation from Matt Porter on IRC that this change will 
be present in the next iteration of his DMA Engine series, which I 
believe brings in the DT SPI support.

Cheers All,
Jack

-- 

   Jack Mitchell (jack@embed.me.uk)
   Embedded Systems Engineer
   http://www.embed.me.uk

--

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-01-04 16:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10 13:23 AM335x BeagleBone SPI Issues Jack Mitchell
2012-12-10 13:53 ` Felipe Balbi
2012-12-10 14:50   ` Jack Mitchell
2012-12-10 14:59     ` Felipe Balbi
2012-12-10 15:19       ` Jack Mitchell
2012-12-10 15:26         ` Shubhrajyoti Datta
2012-12-10 16:18           ` Jack Mitchell
2012-12-10 18:35         ` Felipe Balbi
2012-12-11  6:39           ` Shubhrajyoti Datta
2012-12-11 10:17           ` Jack Mitchell
2012-12-11 10:20             ` Felipe Balbi
2012-12-11 10:38               ` Jack Mitchell
2012-12-11 11:48                 ` Felipe Balbi
2012-12-11 14:27                   ` Felipe Balbi
2012-12-11 15:23                     ` Jack Mitchell
2012-12-11 16:15                       ` Felipe Balbi
2012-12-11 15:22             ` Ben Gamari
2012-12-11 16:24               ` Jack Mitchell
2012-12-11 16:36                 ` Jack Mitchell
2012-12-11 17:02                 ` Jack Mitchell
2013-01-04 14:46                   ` Jan Lübbe
2013-01-04 16:21                     ` Jack Mitchell
2013-01-04 16:36                       ` Jack Mitchell [this message]
2012-12-11 17:03                 ` Felipe Balbi
2012-12-11 17:52                   ` Felipe Balbi
2012-12-12  8:07                     ` Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2012-12-10 13:17 Jack Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50E704FF.107@communistcode.co.uk \
    --to=ml@communistcode.co.uk \
    --cc=balbi@ti.com \
    --cc=bgamari.foss@gmail.com \
    --cc=jlu@pengutronix.de \
    --cc=linux-omap@vger.kernel.org \
    --cc=mporter@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).