From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt Date: Fri, 18 Jan 2013 10:44:34 +0530 Message-ID: <50F8DA3A.3090406@ti.com> References: <1358461134-13452-1-git-send-email-jacmet@sunsite.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1358461134-13452-1-git-send-email-jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Peter Korsgaard Cc: michal.bachraty-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, michal.bachraty-6oiIBCxl0MMjD8S081q9vkEOCMrvLtNR@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: linux-omap@vger.kernel.org On 1/18/2013 3:48 AM, Peter Korsgaard wrote: > When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old > U-Boot, not wanting the hassle of 2 files or when using Falcon fast boot > mode in U-Boot), nothing updates the ethernet hwaddr specified for the > CPSW slaves, causing the driver to use a random hwaddr, which is some times > troublesome. > > The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes > more sense to default to these rather than random ones. Add a fixup step > which adds mac-address dt properties using the efuse addresses if the DTB > didn't contain valid ones. > > Signed-off-by: Peter Korsgaard > This implementation looks fine. Acked-by: Mugunthan V N Regards Mugunthan V N