From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
grant.likely@secretlab.ca, linus.walleij@linaro.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static'
Date: Wed, 6 Feb 2013 15:06:27 +0530 [thread overview]
Message-ID: <5112241B.8050207@ti.com> (raw)
In-Reply-To: <51122147.6080708@asianux.com>
On Wednesday 06 February 2013 02:54 PM, Chen Gang wrote:
>
> 'const static ' is not a common order, better to use 'const static' instead.
You mean " use static const instead ", right ?
> building:
> make EXTRA_CFLAGS=-W ARCH=arm
>
> drivers/gpio/gpio-omap.c:1479:
> warning: 'static' is not at beginning of declaration
> drivers/gpio/gpio-omap.c:1485:
> warning: 'static' is not at beginning of declaration
> drivers/gpio/gpio-omap.c:1491:
> warning: 'static' is not at beginning of declaration
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
With change log fixed,
Acked-by: Santosh Shilimkar ,santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2013-02-06 9:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 9:24 [PATCH] drivers/gpio: using common order: let 'static const' instead of 'const static' Chen Gang
2013-02-06 9:36 ` Santosh Shilimkar [this message]
2013-02-06 10:38 ` Chen Gang
2013-02-06 10:41 ` Santosh Shilimkar
2013-02-06 10:44 ` [PATCH v2] " Chen Gang
2013-02-06 10:47 ` Santosh Shilimkar
2013-02-09 14:22 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5112241B.8050207@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=gang.chen@asianux.com \
--cc=grant.likely@secretlab.ca \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).