From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash Date: Wed, 6 Mar 2013 10:46:56 -0600 Message-ID: <51377300.3040809@ti.com> References: <1361899842-30303-1-git-send-email-jon-hunter@ti.com> <1361899842-30303-12-git-send-email-jon-hunter@ti.com> <51360271.1030302@mimc.co.uk> <51360562.20309@ti.com> <51361B46.507@mimc.co.uk> <51362BAB.10403@ti.com> <513664EC.2050508@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:50182 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639Ab3CFQrN (ORCPT ); Wed, 6 Mar 2013 11:47:13 -0500 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Ezequiel Garcia Cc: Mark Jackson , Rob Herring , Grant Likely , Tony Lindgren , Benoit Cousson , device-tree , linux-omap , linux-arm , Daniel Mack On 03/06/2013 05:58 AM, Ezequiel Garcia wrote: > Jon, > > On Tue, Mar 5, 2013 at 6:34 PM, Jon Hunter wrote: >> >> By the way, with this version you should remove "simple-bus" from your >> gpmc node compatible strings. I now call of_platform_device_create() to >> create the child device during the GPMC probe. I think that this is a >> safer approach. >> > > FWIW, using of_platform_device_create() works for my driver. > It seems as simple as using a compatible 'simple-bus', > with the advantage that it allows to create and probe the > child device from its parent. Yes and I think that is safer for these type of drivers. > I'll submit this driver by the end of this week, in case you want > to take a look at it. Ok, but this is not for omap right? Cheers Jon