From: Rajendra Nayak <rnayak@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Piotr Haber <phaber@broadcom.com>,
Mike Turquette <mturquette@linaro.org>,
Paul Walmsley <paul@pwsan.com>,
linux-omap@vger.kernel.org
Subject: Re: 3.8 -> 3.9-rc1 upgrade: old configs broken
Date: Fri, 8 Mar 2013 09:42:15 +0530 [thread overview]
Message-ID: <5139651F.6010404@ti.com> (raw)
In-Reply-To: <20130306203332.GR11806@atomide.com>
On Thursday 07 March 2013 02:03 AM, Tony Lindgren wrote:
> So basically what's going is that __clk_init() calls kzalloc() before
> kmem_cache_init() is done. This happens the first time for sys_clkin_ck
> where we do have clk->num_parents.
>
> With CONFIG_DEBUG_SLAB we actually get an error in __find_general_cachep()
> as generic caches are not yet initialized.
>
> It seems that in the omap case we need to statically allocate clk->parents
> to fix this. I believe we now are overwriting parent clocks..
Actually we are not. It was a known issue that the kzalloc() calls in
__clk_init() for OMAP would fail, since our clock inits happen quite
early. And hence I submitted this patch 'clk: Allow late cache allocation
for clk->parent, commit 7975059d' to Mike, hoping to work this around in some way.
However I seem to have overlooked the fact that we have BUG() some places
with DEBUG turned on.
The right fix obviously is to move all the static clocks for OMAP over to
use dynamic registrations and do them much after the slab is available.
While we are at this, for now like you rightly said, we would need to have
static clk->parents sent over to __clk_init() to fix these crashes with SLAB_DEBUG
enabled.
I am in the middle of travel with no access to hardware. I will get to this on
monday and send a fix over.
regards,
Rajendra
next prev parent reply other threads:[~2013-03-08 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 16:26 3.8 -> 3.9-rc1 upgrade: old configs broken Piotr Haber
2013-03-06 20:33 ` Tony Lindgren
2013-03-08 4:12 ` Rajendra Nayak [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-04 23:22 Aaro Koskinen
2013-03-05 0:35 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139651F.6010404@ti.com \
--to=rnayak@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=paul@pwsan.com \
--cc=phaber@broadcom.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox