From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH 1/3] driver: net: ethernet: cpsw: implement ethtool get/set phy setting Date: Fri, 8 Mar 2013 12:53:18 +0530 Message-ID: <513991E6.5080400@ti.com> References: <1362659421-11884-1-git-send-email-mugunthanvnm@ti.com> <1362659421-11884-2-git-send-email-mugunthanvnm@ti.com> <8762135on4.fsf@dell.be.48ers.dk> <1362686350.2936.43.camel@bwh-desktop.uk.solarflarecom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1362686350.2936.43.camel@bwh-desktop.uk.solarflarecom.com> Sender: netdev-owner@vger.kernel.org To: Ben Hutchings Cc: Peter Korsgaard , netdev@vger.kernel.org, davem@davemloft.net, devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, b-cousson@ti.com, paul@pwsan.com List-Id: linux-omap@vger.kernel.org On 3/8/2013 1:29 AM, Ben Hutchings wrote: > On Thu, 2013-03-07 at 14:24 +0100, Peter Korsgaard wrote: >>>>>>> "M" == Mugunthan V N writes: >> M> This patch implements get/set of the phy settings via ethtool apis >> M> Signed-off-by: Mugunthan V N >> M> --- >> M> Documentation/devicetree/bindings/net/cpsw.txt | 3 +++ >> M> drivers/net/ethernet/ti/cpsw.c | 32 ++++++++++++++++++++++++ >> M> include/linux/platform_data/cpsw.h | 1 + >> M> 3 files changed, 36 insertions(+) >> >> M> diff --git a/Documentation/devicetree/bindings/net/cpsw.txt b/Documentation/devicetree/bindings/net/cpsw.txt >> M> index ecfdf75..8d61300 100644 >> M> --- a/Documentation/devicetree/bindings/net/cpsw.txt >> M> +++ b/Documentation/devicetree/bindings/net/cpsw.txt >> M> @@ -20,6 +20,7 @@ Required properties: >> M> - cpts_clock_shift : Denominator to convert input clock ticks into nanoseconds >> M> - phy_id : Specifies slave phy id >> M> - mac-address : Specifies slave MAC address >> M> +- ethtool-active-slave : Specifies the slave to use for ethtool command >> >> That again sounds like something Linux specific rather than a hardware >> property. > Yes, indeed. Isn't it redundant with the phy_id? > > Ben. phy_id is part of slave data and will be present for both the slaves. so phy_id cannot be used for get/set phy setting until phy framework allows to change settings without going through eth interface. Regards Mugunthan V N