From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories Date: Fri, 08 Mar 2013 10:14:11 -0700 Message-ID: <513A1C63.9050704@wwwdotorg.org> References: <1362648969-13737-1-git-send-email-balbi@ti.com> <513904A4.7040101@wwwdotorg.org> <20130308071453.GD21589@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130308071453.GD21589-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: balbi-l0cyMroinI0@public.gmane.org Cc: Linux USB Mailing List , Greg KH , cbou-JGs/UdohzUI@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On 03/08/2013 12:14 AM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 07, 2013 at 02:20:36PM -0700, Stephen Warren wrote: >> On 03/07/2013 02:35 AM, Felipe Balbi wrote: >>> Hi folks, >>> >>> inspired by Paul's DWC2 patchset which added >>> usb_otg_state_string() (a copy of otg_state_string()) I have >>> now renamed otg_state_string() to usb_otg_state_string(), moved >>> it to usb-common, then moved all phy drivers to >>> drivers/usb/phy/ and completely deleted the otg directory. >>> >>> We're also removing CONFIG_USB_OTG_UTILS since that has lots >>> its meaning long ago. >>> >>> I have compiled all patches with allyes, allno and allmod >>> configs, but please make sure to test on your platforms to make >>> sure we're not leaking any more problems to mainline. >> >> What branch do the patches apply to? They didn't "git am" for me >> on either next-20130305, nor >> git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git >> next. > > they're on top of my testing branch. Ah, thanks. I took that whole branch, built ARM's tegra_defconfig, and see: > warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI > which has unmet direct dependencies (USB_SUPPORT && USB_PHY && > ARM) warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects > USB_ULPI_VIEWPORT which has unmet direct dependencies (USB_SUPPORT > && USB_PHY && USB_ULPI) warning: (ARCH_TEGRA_2x_SOC && > ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct > dependencies (USB_SUPPORT && USB_PHY && ARM) warning: > (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT > which has unmet direct dependencies (USB_SUPPORT && USB_PHY && > USB_ULPI) Manually enabling USB_PHY fixes this. However, this highlights an issue with your removal of all selects (as mentioned in your other email) - it will break perhaps any defconfig that has USB enabled. After enabling USB_PHY, the code builds and runs without issue. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html