From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 6/8] memory: emif: fix timings initialization issue Date: Mon, 11 Mar 2013 11:14:32 +0530 Message-ID: <513D6F40.6080202@ti.com> References: <1362978365-5593-1-git-send-email-lokeshvutla@ti.com> <1362978365-5593-7-git-send-email-lokeshvutla@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1362978365-5593-7-git-send-email-lokeshvutla@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Lokesh Vutla Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Dmytryshyn List-Id: linux-omap@vger.kernel.org $subject is too vague. What issue ? Some thing like "Fix the incorrect 'size' parameter in memcpy' etc On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote: > From: Oleksandr Dmytryshyn > > The issue was that only the first timings table was added to the > emif platform data at the emif driver registration. All other > timings tables was filled with zeros. Now all emif timings table > are added to the platform data. > Luckily, most of the cases, first table has been re-used for symmetric configuration. > Signed-off-by: Oleksandr Dmytryshyn > Signed-off-by: Lokesh Vutla > --- > drivers/memory/emif.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c > index 02a94fc..f75806a 100644 > --- a/drivers/memory/emif.c > +++ b/drivers/memory/emif.c > @@ -1463,7 +1463,7 @@ static struct emif_data *__init_or_module get_device_details( > if (pd->timings) { > temp = devm_kzalloc(dev, size, GFP_KERNEL); > if (temp) { > - memcpy(temp, pd->timings, sizeof(*pd->timings)); > + memcpy(temp, pd->timings, size); > pd->timings = temp; > } else { > dev_warn(dev, "%s:%d: allocation error\n", __func__, > Patch as such looks good to me. Acked-by: Santosh Shilimkar