From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Andrew Chew <achew@nvidia.com>
Cc: thierry.reding@avionic-design.de, acourbot@nvidia.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight
Date: Wed, 13 Mar 2013 09:51:08 +0100 [thread overview]
Message-ID: <51403DFC.90609@ti.com> (raw)
In-Reply-To: <1363126934-8754-2-git-send-email-achew@nvidia.com>
On 03/12/2013 11:22 PM, Andrew Chew wrote:
> The pwm-backlight driver now takes a mandatory regulator that is gotten
> during driver probe. Initialize a dummy regulator to satisfy this
> requirement.
I can test this tomorrow, but I have one comment:
>
> Signed-off-by: Andrew Chew <achew@nvidia.com>
> ---
> arch/arm/mach-omap2/board-4430sdp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index 35f3ad0..62022c0 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -291,6 +291,10 @@ static struct platform_device sdp4430_leds_pwm = {
> },
> };
>
> +/* Dummy regulator for pwm-backlight driver */
> +static struct regulator_consumer_supply backlight_supply =
> + REGULATOR_SUPPLY("enable", NULL);
'enable' is just too generic, the device name should be also provided:
REGULATOR_SUPPLY("enable", "pwm-backlight");
> +
> static struct platform_pwm_backlight_data sdp4430_backlight_data = {
> .max_brightness = 127,
> .dft_brightness = 127,
> @@ -718,6 +722,7 @@ static void __init omap_4430sdp_init(void)
>
> omap4_i2c_init();
> omap_sfh7741prox_init();
> + regulator_register_always_on(-1, "bl-enable", &backlight_supply, 1, 0);
> platform_add_devices(sdp4430_devices, ARRAY_SIZE(sdp4430_devices));
> omap_serial_init();
> omap_sdrc_init(NULL, NULL);
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-03-13 8:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 22:22 [PATCH 0/2 v2] Add mandatory regulator for all users of pwm-backlight Andrew Chew
2013-03-12 22:22 ` [PATCH 1/2 v2] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight Andrew Chew
2013-03-13 8:51 ` Peter Ujfalusi [this message]
2013-03-13 20:38 ` Andrew Chew
2013-03-13 20:59 ` Thierry Reding
2013-03-13 21:12 ` Andrew Chew
2013-03-12 22:22 ` [PATCH 2/2 v2] pwm_bl: Add mandatory backlight enable regulator Andrew Chew
2013-03-13 8:56 ` Peter Ujfalusi
2013-03-13 10:13 ` Thierry Reding
2013-03-13 21:10 ` Andrew Chew
2013-03-13 21:36 ` Thierry Reding
2013-03-13 21:39 ` Andrew Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51403DFC.90609@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=achew@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=linux-omap@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).