From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] drivers: video: omap2: dss: Use PTR_RET function Date: Wed, 20 Mar 2013 10:44:29 -0500 Message-ID: <5149D95D.2030505@ti.com> References: <1363680194-10404-1-git-send-email-gheorghiuandru@gmail.com> <5149A3D0.2010902@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5149A3D0.2010902@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Tomi Valkeinen Cc: Alexandru Gheorghiu , Florian Tobias Schandinat , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 03/20/2013 06:56 AM, Tomi Valkeinen wrote: > On 2013-03-19 10:03, Alexandru Gheorghiu wrote: >> Use PTR_RET function instead of IS_ERR and PTR_ERR. >> Patch found using coccinelle. >> >> Signed-off-by: Alexandru Gheorghiu >> --- >> drivers/video/omap2/dss/core.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c >> index f8779d4..60cc6fe 100644 >> --- a/drivers/video/omap2/dss/core.c >> +++ b/drivers/video/omap2/dss/core.c >> @@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) >> d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir, >> write, &dss_debug_fops); >> >> - if (IS_ERR(d)) >> - return PTR_ERR(d); >> - >> - return 0; >> + return PTR_RET(d); >> } >> #else /* CONFIG_OMAP2_DSS_DEBUGFS */ >> static inline int dss_initialize_debugfs(void) >> > > Thanks. I'll apply to omapdss tree. Is this correct? If debugfs_create_file() returns a valid pointer, then now dss_debugfs_create_file() will return a non-zero value on success. I don't think this is what you want. A similar case came up recently here [1]. Jon [1] http://comments.gmane.org/gmane.linux.kernel/1455141