From: Jon Hunter <jon-hunter@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Alexandru Gheorghiu <gheorghiuandru@gmail.com>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: video: omap2: dss: Use PTR_RET function
Date: Wed, 20 Mar 2013 13:08:26 -0500 [thread overview]
Message-ID: <5149FB1A.2030608@ti.com> (raw)
In-Reply-To: <5149F9B4.2020400@ti.com>
On 03/20/2013 01:02 PM, Jon Hunter wrote:
>
> On 03/20/2013 11:59 AM, Tomi Valkeinen wrote:
>> On 2013-03-20 17:44, Jon Hunter wrote:
>>>
>>> On 03/20/2013 06:56 AM, Tomi Valkeinen wrote:
>>>> On 2013-03-19 10:03, Alexandru Gheorghiu wrote:
>>>>> Use PTR_RET function instead of IS_ERR and PTR_ERR.
>>>>> Patch found using coccinelle.
>>>>>
>>>>> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
>>>>> ---
>>>>> drivers/video/omap2/dss/core.c | 5 +----
>>>>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
>>>>> index f8779d4..60cc6fe 100644
>>>>> --- a/drivers/video/omap2/dss/core.c
>>>>> +++ b/drivers/video/omap2/dss/core.c
>>>>> @@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
>>>>> d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,
>>>>> write, &dss_debug_fops);
>>>>>
>>>>> - if (IS_ERR(d))
>>>>> - return PTR_ERR(d);
>>>>> -
>>>>> - return 0;
>>>>> + return PTR_RET(d);
>>>>> }
>>>>> #else /* CONFIG_OMAP2_DSS_DEBUGFS */
>>>>> static inline int dss_initialize_debugfs(void)
>>>>>
>>>>
>>>> Thanks. I'll apply to omapdss tree.
>>>
>>> Is this correct? If debugfs_create_file() returns a valid pointer, then
>>> now dss_debugfs_create_file() will return a non-zero value on success. I
>>> don't think this is what you want. A similar case came up recently here [1].
>>
>> Hmm. I don't follow. And I don't understand the post where you referred.
Yes looking at Russell's response I am not sure I following now as it is
also using PTR_RET() and not PTR_ERR(). My eyes deceived me on this one.
Jon
prev parent reply other threads:[~2013-03-20 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 8:03 [PATCH] drivers: video: omap2: dss: Use PTR_RET function Alexandru Gheorghiu
2013-03-20 11:56 ` Tomi Valkeinen
2013-03-20 15:44 ` Jon Hunter
2013-03-20 16:59 ` Tomi Valkeinen
2013-03-20 18:02 ` Jon Hunter
2013-03-20 18:08 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149FB1A.2030608@ti.com \
--to=jon-hunter@ti.com \
--cc=FlorianSchandinat@gmx.de \
--cc=gheorghiuandru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).