From: kishon <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: balbi@ti.com, gregkh@linuxfoundation.org, arnd@arndb.de,
akpm@linux-foundation.org, rob@landley.net, davem@davemloft.net,
cesarb@cesarb.net, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
b-cousson@ti.com, linux@arm.linux.org.uk, eballetbo@gmail.com,
javier@dowhile0.org, mchehab@redhat.com,
santosh.shilimkar@ti.com, broonie@opensource.wolfsonmicro.com,
swarren@nvidia.com, linux-doc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/6] ARM: OMAP: USB: Add phy binding information
Date: Thu, 21 Mar 2013 11:18:12 +0530 [thread overview]
Message-ID: <514A9F1C.6080609@ti.com> (raw)
In-Reply-To: <20130320165141.GP16413@atomide.com>
Hi,
On Wednesday 20 March 2013 10:21 PM, Tony Lindgren wrote:
> * Kishon Vijay Abraham I <kishon@ti.com> [130320 02:17]:
>>
>> --- a/arch/arm/mach-omap2/board-2430sdp.c
>> +++ b/arch/arm/mach-omap2/board-2430sdp.c
>> @@ -265,6 +266,7 @@ static void __init omap_2430sdp_init(void)
>>
>> omap_mux_init_signal("usb0hs_stp", OMAP_PULL_ENA | OMAP_PULL_UP);
>> usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
>> + phy_bind("musb-hdrc.0.auto", 0, "twl4030_usb");
>> usb_musb_init(NULL);
>>
>> board_smc91x_init();
>> --- a/arch/arm/mach-omap2/board-3430sdp.c
>> +++ b/arch/arm/mach-omap2/board-3430sdp.c
>> @@ -601,6 +602,7 @@ static void __init omap_3430sdp_init(void)
>> omap_serial_init();
>> omap_sdrc_init(hyb18m512160af6_sdrc_params, NULL);
>> usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
>> + phy_bind("musb-hdrc.0.auto", 0, "twl4030_usb");
>> usb_musb_init(NULL);
>> board_smc91x_init();
>> board_flash_init(sdp_flash_partitions, chip_sel_3430, 0);
>
> Can't you call phy_bind() from usb_musb_init() with the default
> values automatically when usb_musb_init() is passed NULL?
>
> That way you don't have to patch every board-*.c file with the
> same lines, and don't need to include <linux/phy/phy.h> in each
> board-*.c file.
>
>> --- a/arch/arm/mach-omap2/board-4430sdp.c
>> +++ b/arch/arm/mach-omap2/board-4430sdp.c
>> @@ -32,6 +32,7 @@
>> #include <linux/platform_data/omap4-keypad.h>
>> #include <linux/usb/musb.h>
>> #include <linux/usb/phy.h>
>> +#include <linux/phy/phy.h>
>>
>> #include <asm/mach-types.h>
>> #include <asm/mach/arch.h>
>> @@ -725,6 +726,7 @@ static void __init omap_4430sdp_init(void)
>> omap4_twl6030_hsmmc_init(mmc);
>>
>> usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto");
>> + phy_bind("musb-hdrc.0.auto", 0, "omap-usb2.1.auto");
>> usb_musb_init(&musb_board_data);
>>
>> status = omap_ethernet_init();
>
> Here usb_musb_init() gets called with musb_board_data, so
> keeping the phy_bind() in the board-4430sdp.c can then override
> the default in usb_musb_init().
Currently phy_bind has a limitation to do that. Will change phy_bind()
and have your comment incorporated.
Thanks
Kishon
next prev parent reply other threads:[~2013-03-21 5:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 9:11 [PATCH v3 0/6] Generic PHY Framework Kishon Vijay Abraham I
2013-03-20 9:12 ` [PATCH v3 1/6] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2013-03-20 22:36 ` Sylwester Nawrocki
2013-03-21 5:46 ` kishon
[not found] ` <1363770725-13717-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-04-15 11:34 ` Grant Likely
2013-04-15 12:26 ` Kishon Vijay Abraham I
2013-04-15 19:50 ` Grant Likely
2013-04-16 10:18 ` Kishon Vijay Abraham I
2013-04-19 9:09 ` Grant Likely
2013-04-22 6:09 ` Kishon Vijay Abraham I
[not found] ` <1363770725-13717-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-03-20 9:12 ` [PATCH v3 2/6] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-03-20 9:12 ` [PATCH v3 6/6] usb: musb: omap2430: " Kishon Vijay Abraham I
2013-04-19 10:52 ` [PATCH v3 0/6] Generic PHY Framework Sekhar Nori
2013-03-20 9:12 ` [PATCH v3 3/6] usb: otg: twl4030: use the new generic PHY framework Kishon Vijay Abraham I
2013-03-20 9:12 ` [PATCH v3 4/6] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-03-20 16:51 ` Tony Lindgren
2013-03-21 5:48 ` kishon [this message]
2013-03-20 9:12 ` [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-03-20 20:59 ` Stephen Warren
2013-03-21 6:23 ` kishon
2013-03-21 17:10 ` Stephen Warren
[not found] ` <514B3EEF.3080705-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-22 9:20 ` Kishon Vijay Abraham I
2013-04-15 10:20 ` [PATCH v3 0/6] Generic PHY Framework Grant Likely
2013-04-15 10:36 ` Kishon Vijay Abraham I
2013-04-15 11:27 ` Sylwester Nawrocki
2013-04-15 12:26 ` Grant Likely
2013-04-15 12:33 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514A9F1C.6080609@ti.com \
--to=kishon@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=eballetbo@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=javier@dowhile0.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mchehab@redhat.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@nvidia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).