From: Rob Herring <robherring2@gmail.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Mark Rutland <mark.rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Will Deacon <Will.Deacon@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init
Date: Mon, 25 Mar 2013 21:19:46 -0500 [thread overview]
Message-ID: <515105C2.9060002@gmail.com> (raw)
In-Reply-To: <5150D54D.1070004@linaro.org>
On 03/25/2013 05:53 PM, John Stultz wrote:
> On 03/25/2013 03:36 PM, Arnd Bergmann wrote:
>> On Monday 25 March 2013, Rob Herring wrote:
>>> I count integrator-cp, realview, versatile and non-DT VExpress that do
>>> this (not surprisingly) and 25 platforms or timer implementations plus
>>> arm64 that do sched_clock setup in time_init. What's broken by not
>>> moving these earlier?
>> timekeeping_init() will leave the persistent_clock_exist variable as
>> "false",
>> which is read in rtc_suspend() and timekeeping_inject_sleeptime().
>
> Are you mixing up the persistent_clock and sched_clock here? From a
> generic stand-point they have different requirements.
Yes. We're talking about sched_clock here. What would be the benefit of
having it setup before sched_init vs. later in time_init?
Rob
next prev parent reply other threads:[~2013-03-26 2:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 22:34 [PATCH] ARM: convert arm/arm64 arch timer to use CLKSRC_OF init Rob Herring
2013-03-21 11:06 ` Mark Rutland
2013-03-21 11:35 ` Marc Zyngier
2013-03-21 12:52 ` Rob Herring
2013-03-25 17:26 ` Russell King - ARM Linux
2013-03-25 21:28 ` Rob Herring
2013-03-25 22:36 ` Arnd Bergmann
2013-03-25 22:53 ` John Stultz
2013-03-26 2:19 ` Rob Herring [this message]
2013-03-26 9:56 ` Arnd Bergmann
2013-03-25 23:07 ` Catalin Marinas
2013-04-23 21:23 ` [PATCH] ARM: OMAP: remove unused variable Arnd Bergmann
2013-04-23 21:26 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515105C2.9060002@gmail.com \
--to=robherring2@gmail.com \
--cc=Catalin.Marinas@arm.com \
--cc=Will.Deacon@arm.com \
--cc=arnd@arndb.de \
--cc=horms@verge.net.au \
--cc=john.stultz@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).