From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 1/9] ARM: OMAP4+: Use common scratchpad SAR RAM offsets for all architectures Date: Thu, 28 Mar 2013 02:19:42 +0530 Message-ID: <51535B66.60307@ti.com> References: <1361373527-21695-1-git-send-email-santosh.shilimkar@ti.com> <1361373527-21695-2-git-send-email-santosh.shilimkar@ti.com> <87mwto7ki5.fsf@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:45540 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752720Ab3C0Uru (ORCPT ); Wed, 27 Mar 2013 16:47:50 -0400 In-Reply-To: <87mwto7ki5.fsf@linaro.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: linux-omap@vger.kernel.org, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Tero Kristo On Thursday 28 March 2013 12:11 AM, Kevin Hilman wrote: > Santosh Shilimkar writes: > >> From: Tero Kristo >> >> Simplifies code and also allows the re-use as is on OMAP5 devices. > > nit: changelog here is rather weak. It claims "simplifies code" but > it's not obvious from the patch how changing a few #defines does that. > I agree. Basically the offset are chosen such a way that they can work on OMAP4 and OMAP5 instead of having two separate sets. Will expand the changelog to make it clear. Regards, Santosh