linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: balbi@ti.com, Peter Korsgaard <jacmet@sunsite.dk>,
	"Mohammed, Afzal" <afzal@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Rob Landley <rob@landley.net>,
	"Santhapuri, Damodar" <damodar.santhapuri@ti.com>,
	"B, Ravi" <ravibabu@ti.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 0/5] usb: musb: am335x support
Date: Wed, 03 Apr 2013 15:16:05 +0200	[thread overview]
Message-ID: <515C2B95.7050408@gmail.com> (raw)
In-Reply-To: <62C108BE-894A-4F1D-BE85-14DB3217120E@dominion.thruhere.net>

On 03.04.2013 15:12, Koen Kooi wrote:
> 
> Op 3 apr. 2013, om 15:09 heeft Felipe Balbi <balbi@ti.com> het
> volgende geschreven:
> 
>> Hi,
>> 
>> On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote:
>>> On 03.04.2013 14:04, Felipe Balbi wrote:
>>>> On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote:
>>> 
>>>>> Felipe, could you explain the background on how the dsps
>>>>> driver is supposed to work in host mode at boot time with the
>>>>> rework of the driver you did for 3.7? It might just be me not
>>>>> understanding the rationale behind all these changes, but
>>>>> appearantly, I'm not the only one who's affected by that.
>>>> 
>>>> right, so the idea with that was to drop the huge amount of
>>>> ifdeferry hack from the MUSB driver. It would be great if
>>>> someone would send *CLEAN* patches adding Kconfig-based role
>>>> choices again.
>>> 
>>> Are Kconfig-based rules really what we want here after all?
>>> Wouldn't run-time configured settings make much more sense,
>>> considering that
>> 
>> we need both. Say that you want to build a product with MUSB
>> hardwired as host, why would you enable gadget framework ?
>> 
>> I can think of at least am335x where this would be perfectly
>> plausible (no EHCI available, only MUSB).
> 
> Nice that you mention am335x, since the beaglebone has 2 MUSB
> controllers: one hardwired as host and one hardwired as slave. So how
> will KConfig options solve that?
> 

You would enable DUAL_ROLE and then let run-time code sort out the
actual config. Which is what most people would do if they are uncertain,
and which leaves the Kconfig option only for opting out some binary size.

Also, we already have CONFIG_USB_GADGET_MUSB_HDRC which is there to
remove all the gadget-only bits, right?


Daniel

  reply	other threads:[~2013-04-03 13:16 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 16:31 [PATCH 0/5] usb: musb: am335x support Afzal Mohammed
2012-11-02 16:32 ` [PATCH 1/5] usb: musb: dsps: remove platform callback Afzal Mohammed
     [not found] ` <cover.1351870620.git.afzal-l0cyMroinI0@public.gmane.org>
2012-11-02 16:32   ` [PATCH 2/5] usb: musb: dsps: reduce musb instance to one Afzal Mohammed
2012-11-02 16:32   ` [PATCH 3/5] usb: musb: dsps: get resources by index Afzal Mohammed
2012-11-02 16:32 ` [PATCH 4/5] usb: musb: dsps: dt binding - add resources, example Afzal Mohammed
2012-11-06 13:02   ` Felipe Balbi
     [not found]     ` <20121106130245.GK11931-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-06 14:37       ` Afzal Mohammed
2012-11-02 16:32 ` [PATCH 5/5] usb: musb: dsps: control module handling (quirk) Afzal Mohammed
2012-11-02 19:36 ` [PATCH 0/5] usb: musb: am335x support Daniel Mack
2012-11-03  2:40   ` B, Ravi
2012-11-03  7:33   ` Mohammed, Afzal
     [not found]     ` <C8443D0743D26F4388EA172BF4E2A7A93EA0A1F2-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-03-01 21:57       ` Daniel Mack
     [not found]         ` <51312430.6060306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-02  1:36           ` Daniel Mack
2013-03-02 16:05         ` Koen Kooi
2013-03-02 17:00           ` Daniel Mack
2013-03-03 22:24         ` Peter Korsgaard
2013-03-03 23:53           ` Daniel Mack
     [not found]             ` <5133E268.5010604-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-07 12:51               ` Daniel Mack
     [not found]                 ` <51388D64.9000005-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-08 16:44                   ` Daniel Mack
     [not found]                     ` <513A1580.90303-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-19 13:10                       ` Daniel Mack
2013-03-19 13:27                         ` Peter Korsgaard
     [not found]                           ` <87620nwmd2.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
2013-04-03 12:00                             ` Daniel Mack
     [not found]                               ` <515C19D7.6080702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-03 12:04                                 ` Felipe Balbi
     [not found]                                   ` <20130403120454.GX25837-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-04-03 12:11                                     ` Daniel Mack
2013-04-03 12:43                                   ` Daniel Mack
     [not found]                                     ` <515C23D4.3010206-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-03 13:09                                       ` Felipe Balbi
     [not found]                                         ` <20130403130807.GB14680-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-04-03 13:12                                           ` Koen Kooi
2013-04-03 13:16                                             ` Daniel Mack [this message]
2013-04-03 13:46                                               ` Felipe Balbi
     [not found]                                             ` <62C108BE-894A-4F1D-BE85-14DB3217120E-QLwJDigV5abLmq1fohREcCpxlwaOVQ5f@public.gmane.org>
2013-04-03 13:44                                               ` Felipe Balbi
2013-04-04  5:10                                         ` B, Ravi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515C2B95.7050408@gmail.com \
    --to=zonque@gmail.com \
    --cc=afzal@ti.com \
    --cc=balbi@ti.com \
    --cc=damodar.santhapuri@ti.com \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=jacmet@sunsite.dk \
    --cc=kishon@ti.com \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ravibabu@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).