From: Tomi Valkeinen <tomi.valkeinen@iki.fi>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Tony Lindgren <tony@atomide.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org,
Christoph Fritz <chf.fritz@googlemail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH] RTC: rtc-twl: Convert to module_platform_driver() and relocate reg_map init
Date: Tue, 16 Apr 2013 11:10:56 +0300 [thread overview]
Message-ID: <516D0790.7090902@iki.fi> (raw)
In-Reply-To: <1366098262-20726-1-git-send-email-peter.ujfalusi@ti.com>
Hi,
On 2013-04-16 10:44, Peter Ujfalusi wrote:
> Convert the driver to use module_platform_driver() to register the platform
> driver and relocate the rtc_reg_map initialization to platform driver's
> probe function.
> In this way we can make sure that the twl-core has been already probed since
> the core driver will create the device at the end of it's probe function.
>
> Reported-by: Christoph Fritz <chf.fritz@googlemail.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
I think there are two distinct things here. The actual fix for the
regmap, and a module_platform_driver cleanup. I would suggest having
them in separate patches.
And even if these are combined, I think the patch subject and
description should talk about fixing the regmap bug. Now it's rather
unclear that an actual bug is being fixed.
Tomi
next prev parent reply other threads:[~2013-04-16 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 7:44 [PATCH] RTC: rtc-twl: Convert to module_platform_driver() and relocate reg_map init Peter Ujfalusi
2013-04-16 8:10 ` Tomi Valkeinen [this message]
2013-04-16 8:16 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D0790.7090902@iki.fi \
--to=tomi.valkeinen@iki.fi \
--cc=a.zummo@towertech.it \
--cc=chf.fritz@googlemail.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rtc-linux@googlegroups.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).