From: "Vincent Stehlé" <v-stehle@ti.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux@arm.linux.org.uk, b-cousson@ti.com, tony@atomide.com,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2] ARM:dts:omap4-panda:Update the LED support for the panda DTS
Date: Thu, 18 Apr 2013 11:30:00 +0200 [thread overview]
Message-ID: <516FBD18.3060501@ti.com> (raw)
In-Reply-To: <1366229760-4808-1-git-send-email-dmurphy@ti.com>
On 04/17/2013 10:16 PM, Dan Murphy wrote:
> The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es
> are different.
(..)
> diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi
> index 03bd60d..0c48f6b 100644
> --- a/arch/arm/boot/dts/omap4-panda-common.dtsi
> +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi
(..)
> @@ -135,6 +136,25 @@
> 0xf0 0x118 /* i2c4_sda PULLUP | INPUTENABLE | MODE0 */
> >;
> };
> +
> + led_gpio_pins: pinmux_leds_pins {
> + pinctrl-single,pins = <
> + >;
> + };
> +};
Hi,
FYI, there was a recent discussion precisely on this topic, where Tomy
suggested to remove the empty section:
http://marc.info/?l=linux-omap&m=136546635409232&w=2
Apart from that, I just tested your patch on top of Tomy's
omap-for-v3.10/dt branch and it is working fine for me on PandaBoards
EA3, A4 and ES.
Tested-by: Vincent Stehlé <v-stehle@ti.com>
Best regards,
V.
next prev parent reply other threads:[~2013-04-18 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 20:16 [PATCHv2] ARM:dts:omap4-panda:Update the LED support for the panda DTS Dan Murphy
2013-04-18 9:30 ` Vincent Stehlé [this message]
2013-04-18 18:31 ` Dan Murphy
2013-05-08 23:47 ` Tony Lindgren
2013-05-09 18:08 ` Dan Murphy
[not found] ` <518BE617.1080509-l0cyMroinI0@public.gmane.org>
2013-05-09 18:45 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516FBD18.3060501@ti.com \
--to=v-stehle@ti.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmurphy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).