From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Luciano Coelho <coelho@ti.com>, Roger Quadros <rogerq@ti.com>,
linux-arm-kernel@lists.infradead.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Ravi Babu <ravibabu@ti.com>,
Ruslan Bilovol <ruslan.bilovol@ti.com>
Subject: Re: Multiple issues with omap4 panda es in linux next
Date: Mon, 22 Apr 2013 13:24:56 +0300 [thread overview]
Message-ID: <51750FF8.6000401@ti.com> (raw)
In-Reply-To: <5174FE16.6080307@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]
On 2013-04-22 12:08, Tomi Valkeinen wrote:
> On 2013-04-19 20:13, Tony Lindgren wrote:
>
>> 3. DSS fails with DT booting
>>
>> Works with legacy booting but fails with DT. I'm almost certain
>> the DT booting was working last week or so?
>>
>> This is what I now get with DT booting:
>>
>> omapdss DSI error: can't get VDDS_DSI regulator
>> omapdss HDMI error: can't get VDDA_HDMI_DAC regulator
>> omapdss HDMI error: device hdmi init failed: -517
>> omapdss CORE error: driver probe failed: -22
>> ...
>
> I think this is the issue Christoph Fritz reported earlier, DSS is being
> initialized before TWL, and thus DSS doesn't find the regulators.
>
> The proper fix is of course to make DSS support EPROBE_DEFER, but that's
> easier said than done. I'll have a look if I can get it working enough
> to fix this issue.
Yes, it seems delayed regulator initialization brought up this issue.
I hacked DSI driver of omapdss and Taal panel driver to somewhat work
with EPROBE_DEFER. But then the issue was with omapfb.
omapfb is currently set to start at late_initcall, so that omapdss and
panels are loaded before omapfb. But even that's not late enough to get
the regulators for omapdss. It seems the regulators get also initialized
at the late_initcall level. Changing omapfb to late_initcall_sync was
late enough to get things working.
Again, making omapdss, panel drivers and omapfb support EPROBE_DEFER and
dynamic panel driver insertion is the proper fix, but it's a big job,
and there are "interesting" issues with it (like how to know if a panel
device will ever get a driver loaded).
But is there something wrong with the TWL and regulators? late_initcall
sounds rather late for such a core resource. Even if all drivers
supported EPROBE_DEFER, won't it cause extra delays in the boot as
drivers are getting probed multiple times?
As for fixing the DSS problem for 3.10, I don't have any ideas except
pure hacks. I'll continue studying this.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
next prev parent reply other threads:[~2013-04-22 10:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 17:13 Multiple issues with omap4 panda es in linux next Tony Lindgren
2013-04-19 17:41 ` Santosh Shilimkar
2013-04-19 17:44 ` Tony Lindgren
2013-04-19 17:53 ` Santosh Shilimkar
2013-04-19 18:18 ` Tony Lindgren
2013-04-25 13:58 ` Kevin Hilman
2013-04-26 8:40 ` Santosh Shilimkar
2013-04-22 7:49 ` Felipe Balbi
2013-04-22 8:41 ` Kishon Vijay Abraham I
2013-04-22 18:03 ` Tony Lindgren
2013-04-23 15:10 ` Kishon Vijay Abraham I
2013-04-23 17:23 ` Tony Lindgren
2013-04-23 21:31 ` Tony Lindgren
2013-04-23 23:16 ` Tony Lindgren
2013-04-24 5:41 ` Kishon Vijay Abraham I
2013-04-24 19:08 ` Tony Lindgren
2013-04-24 19:23 ` Tony Lindgren
2013-04-25 9:04 ` Felipe Balbi
2013-04-25 15:01 ` Tony Lindgren
2013-04-25 15:13 ` Felipe Balbi
2013-04-22 9:08 ` Tomi Valkeinen
2013-04-22 10:24 ` Tomi Valkeinen [this message]
2013-04-22 12:21 ` Grygorii Strashko
2013-04-22 18:08 ` Tony Lindgren
2013-04-23 13:53 ` Grygorii Strashko
2013-04-23 17:31 ` Tony Lindgren
2013-04-24 19:44 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51750FF8.6000401@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=balbi@ti.com \
--cc=coelho@ti.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=ravibabu@ti.com \
--cc=rogerq@ti.com \
--cc=ruslan.bilovol@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).