* [PATCHv2 0/3] arm: enable TI SoC thermal driver
@ 2013-05-15 14:58 Eduardo Valentin
2013-05-15 14:58 ` [PATCHv2 1/3] arm: introduce config HAS_BANDGAP Eduardo Valentin
` (2 more replies)
0 siblings, 3 replies; 18+ messages in thread
From: Eduardo Valentin @ 2013-05-15 14:58 UTC (permalink / raw)
To: tony; +Cc: linux-omap, Eduardo Valentin
Hello,
Idea is to add the missing bits under arch/arm/*omap* required
to enable by default the ti-soc-thermal driver. I am planing to
move it out of staging tree. It would be interesting to get
feedback from other ppl. By enabling it by default we could reach
more ppl for testing it across the supported chips.
The difference from v1 is just that patch 01 doe snot include the
dts prefix, as it is not supposed to be DTS related.
BR,
Eduardo Valentin (3):
arm: introduce config HAS_BANDGAP
arm: dts: add bandgap entry for OMAP443x devices
arm: dts: add bandgap entry for OMAP4460 devices
arch/arm/Kconfig | 3 +++
arch/arm/boot/dts/omap443x.dtsi | 4 ++++
arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++
arch/arm/mach-omap2/Kconfig | 1 +
4 files changed, 17 insertions(+)
--
1.8.2.1.342.gfa7285d
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCHv2 1/3] arm: introduce config HAS_BANDGAP 2013-05-15 14:58 [PATCHv2 0/3] arm: enable TI SoC thermal driver Eduardo Valentin @ 2013-05-15 14:58 ` Eduardo Valentin 2013-05-31 15:03 ` Eduardo Valentin 2013-05-31 15:12 ` Fabio Estevam 2013-05-15 14:58 ` [PATCHv2 2/3] arm: dts: add bandgap entry for OMAP443x devices Eduardo Valentin 2013-05-15 14:58 ` [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices Eduardo Valentin 2 siblings, 2 replies; 18+ messages in thread From: Eduardo Valentin @ 2013-05-15 14:58 UTC (permalink / raw) To: tony Cc: linux-omap, Eduardo Valentin, Russell King, linux-arm-kernel, linux-kernel Introduce HAS_BANDGAP config entry. This config is a boolean value so that arch code can flag is they feature a bandgap device. This config entry follows the same idea behind ARCH_HAS_CPUFREQ. Cc: Russell King <linux@arm.linux.org.uk> Cc: Tony Lindgren <tony@atomide.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- arch/arm/Kconfig | 3 +++ arch/arm/mach-omap2/Kconfig | 1 + 2 files changed, 4 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index d423d58..bcbdec9 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -174,6 +174,9 @@ config ARCH_HAS_CPUFREQ and that the relevant menu configurations are displayed for it. +config ARCH_HAS_BANDGAP + bool + config GENERIC_HWEIGHT bool default y diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index f49cd51..8620ab5 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -4,6 +4,7 @@ config ARCH_OMAP config ARCH_OMAP2PLUS bool "TI OMAP2/3/4/5 SoCs with device tree support" if (ARCH_MULTI_V6 || ARCH_MULTI_V7) select ARCH_HAS_CPUFREQ + select ARCH_HAS_BANDGAP select ARCH_HAS_HOLES_MEMORYMODEL select ARCH_OMAP select ARCH_REQUIRE_GPIOLIB -- 1.8.2.1.342.gfa7285d ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCHv2 1/3] arm: introduce config HAS_BANDGAP 2013-05-15 14:58 ` [PATCHv2 1/3] arm: introduce config HAS_BANDGAP Eduardo Valentin @ 2013-05-31 15:03 ` Eduardo Valentin 2013-05-31 15:12 ` Fabio Estevam 1 sibling, 0 replies; 18+ messages in thread From: Eduardo Valentin @ 2013-05-31 15:03 UTC (permalink / raw) To: Eduardo Valentin Cc: tony, linux-omap, Russell King, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1656 bytes --] Tony, Russell, On 15-05-2013 10:58, Eduardo Valentin wrote: > Introduce HAS_BANDGAP config entry. This config is a > boolean value so that arch code can flag is they > feature a bandgap device. > > This config entry follows the same idea behind > ARCH_HAS_CPUFREQ. > > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Tony Lindgren <tony@atomide.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> Gentle reminder on this one. > --- > arch/arm/Kconfig | 3 +++ > arch/arm/mach-omap2/Kconfig | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index d423d58..bcbdec9 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -174,6 +174,9 @@ config ARCH_HAS_CPUFREQ > and that the relevant menu configurations are displayed for > it. > > +config ARCH_HAS_BANDGAP > + bool > + > config GENERIC_HWEIGHT > bool > default y > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index f49cd51..8620ab5 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -4,6 +4,7 @@ config ARCH_OMAP > config ARCH_OMAP2PLUS > bool "TI OMAP2/3/4/5 SoCs with device tree support" if (ARCH_MULTI_V6 || ARCH_MULTI_V7) > select ARCH_HAS_CPUFREQ > + select ARCH_HAS_BANDGAP > select ARCH_HAS_HOLES_MEMORYMODEL > select ARCH_OMAP > select ARCH_REQUIRE_GPIOLIB > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 295 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 1/3] arm: introduce config HAS_BANDGAP 2013-05-15 14:58 ` [PATCHv2 1/3] arm: introduce config HAS_BANDGAP Eduardo Valentin 2013-05-31 15:03 ` Eduardo Valentin @ 2013-05-31 15:12 ` Fabio Estevam 2013-06-04 12:32 ` Eduardo Valentin 1 sibling, 1 reply; 18+ messages in thread From: Fabio Estevam @ 2013-05-31 15:12 UTC (permalink / raw) To: Eduardo Valentin Cc: tony, linux-omap, Russell King, linux-kernel, linux-arm-kernel On Wed, May 15, 2013 at 11:58 AM, Eduardo Valentin <eduardo.valentin@ti.com> wrote: > Introduce HAS_BANDGAP config entry. This config is a > boolean value so that arch code can flag is they > feature a bandgap device. > > This config entry follows the same idea behind > ARCH_HAS_CPUFREQ. It would be nice if you explain what BANDGAP means here, since you introduce this option in this patch. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 1/3] arm: introduce config HAS_BANDGAP 2013-05-31 15:12 ` Fabio Estevam @ 2013-06-04 12:32 ` Eduardo Valentin 2013-06-04 12:42 ` [PATCHv3 " Eduardo Valentin 0 siblings, 1 reply; 18+ messages in thread From: Eduardo Valentin @ 2013-06-04 12:32 UTC (permalink / raw) To: Fabio Estevam Cc: Eduardo Valentin, tony, linux-omap, Russell King, linux-kernel, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 978 bytes --] Fabio, On 31-05-2013 11:12, Fabio Estevam wrote: > On Wed, May 15, 2013 at 11:58 AM, Eduardo Valentin > <eduardo.valentin@ti.com> wrote: >> Introduce HAS_BANDGAP config entry. This config is a >> boolean value so that arch code can flag is they >> feature a bandgap device. >> >> This config entry follows the same idea behind >> ARCH_HAS_CPUFREQ. > > It would be nice if you explain what BANDGAP means here, since you > introduce this option in this patch. > > Yeah, I didnt do it because bandgap is a common term used in digital circuits [1,2]. Also, as in this patch we do not add term different from the common used bandgap term, I believe it is self explanatory. I any case, I am resending with minor explanation. [1] - http://en.wikipedia.org/wiki/Bandgap_voltage_reference [2] - http://en.wikipedia.org/wiki/Silicon_bandgap_temperature_sensor -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 295 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCHv3 1/3] arm: introduce config HAS_BANDGAP 2013-06-04 12:32 ` Eduardo Valentin @ 2013-06-04 12:42 ` Eduardo Valentin 0 siblings, 0 replies; 18+ messages in thread From: Eduardo Valentin @ 2013-06-04 12:42 UTC (permalink / raw) To: tony Cc: Eduardo Valentin, Russell King, linux-arm-kernel, linux-omap, linux-kernel, Fabio Stevam Bandgap is a device used to measure temperature on electronic equipments. It is widely used in digital integrated circuits. It is based on the dependency between silicon voltage and temperature. This patch introduce HAS_BANDGAP config entry. This config is a boolean value so that arch code can flag if they feature a bandgap device. This config entry follows the same idea behind ARCH_HAS_CPUFREQ. Cc: Russell King <linux@arm.linux.org.uk> Cc: Tony Lindgren <tony@atomide.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-omap@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Fabio Stevam <festevam@gmail.com> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- arch/arm/Kconfig | 3 +++ arch/arm/mach-omap2/Kconfig | 1 + 2 files changed, 4 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index d423d58..bcbdec9 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -174,6 +174,9 @@ config ARCH_HAS_CPUFREQ and that the relevant menu configurations are displayed for it. +config ARCH_HAS_BANDGAP + bool + config GENERIC_HWEIGHT bool default y diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index f49cd51..8620ab5 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -4,6 +4,7 @@ config ARCH_OMAP config ARCH_OMAP2PLUS bool "TI OMAP2/3/4/5 SoCs with device tree support" if (ARCH_MULTI_V6 || ARCH_MULTI_V7) select ARCH_HAS_CPUFREQ + select ARCH_HAS_BANDGAP select ARCH_HAS_HOLES_MEMORYMODEL select ARCH_OMAP select ARCH_REQUIRE_GPIOLIB -- 1.8.2.1.342.gfa7285d ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCHv2 2/3] arm: dts: add bandgap entry for OMAP443x devices 2013-05-15 14:58 [PATCHv2 0/3] arm: enable TI SoC thermal driver Eduardo Valentin 2013-05-15 14:58 ` [PATCHv2 1/3] arm: introduce config HAS_BANDGAP Eduardo Valentin @ 2013-05-15 14:58 ` Eduardo Valentin 2013-05-15 14:58 ` [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices Eduardo Valentin 2 siblings, 0 replies; 18+ messages in thread From: Eduardo Valentin @ 2013-05-15 14:58 UTC (permalink / raw) To: tony Cc: linux-omap, Eduardo Valentin, Benoît Cousson, Russell King, devicetree-discuss, linux-arm-kernel, linux-kernel This patch add the bandgap entry for OMAP4430 devices. Cc: "Benoît Cousson" <b-cousson@ti.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Russell King <linux@arm.linux.org.uk> Cc: linux-omap@vger.kernel.org Cc: devicetree-discuss@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- arch/arm/boot/dts/omap443x.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap443x.dtsi index cccf39a..8d6c968 100644 --- a/arch/arm/boot/dts/omap443x.dtsi +++ b/arch/arm/boot/dts/omap443x.dtsi @@ -24,4 +24,8 @@ clock-latency = <300000>; /* From legacy driver */ }; }; + bandgap { + reg = <0x4a002260 0x4 0x4a00232C 0x4>; + compatible = "ti,omap4430-bandgap"; + }; }; -- 1.8.2.1.342.gfa7285d -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-15 14:58 [PATCHv2 0/3] arm: enable TI SoC thermal driver Eduardo Valentin 2013-05-15 14:58 ` [PATCHv2 1/3] arm: introduce config HAS_BANDGAP Eduardo Valentin 2013-05-15 14:58 ` [PATCHv2 2/3] arm: dts: add bandgap entry for OMAP443x devices Eduardo Valentin @ 2013-05-15 14:58 ` Eduardo Valentin 2013-05-15 15:23 ` Benoit Cousson 2 siblings, 1 reply; 18+ messages in thread From: Eduardo Valentin @ 2013-05-15 14:58 UTC (permalink / raw) To: tony Cc: linux-omap, Eduardo Valentin, Benoît Cousson, Russell King, devicetree-discuss, linux-arm-kernel, linux-kernel Include bandgap devices for OMAP4460 devices. Cc: "Benoît Cousson" <b-cousson@ti.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Russell King <linux@arm.linux.org.uk> Cc: linux-omap@vger.kernel.org Cc: devicetree-discuss@lists.ozlabs.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi index 2cf227c..e5bfbfe 100644 --- a/arch/arm/boot/dts/omap4460.dtsi +++ b/arch/arm/boot/dts/omap4460.dtsi @@ -29,4 +29,13 @@ <0 55 0x4>; ti,hwmods = "debugss"; }; + + bandgap { + reg = <0x4a002260 0x4 + 0x4a00232C 0x4 + 0x4a002378 0x18>; + compatible = "ti,omap4460-bandgap"; + interrupts = <0 126 4>; /* talert */ + ti,tshut-gpio = <86>; + }; }; -- 1.8.2.1.342.gfa7285d ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-15 14:58 ` [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices Eduardo Valentin @ 2013-05-15 15:23 ` Benoit Cousson 2013-05-15 16:36 ` Eduardo Valentin 0 siblings, 1 reply; 18+ messages in thread From: Benoit Cousson @ 2013-05-15 15:23 UTC (permalink / raw) To: Eduardo Valentin Cc: tony, linux-omap, Russell King, devicetree-discuss, linux-arm-kernel, linux-kernel Hi Eduardo, On 05/15/2013 04:58 PM, Eduardo Valentin wrote: > Include bandgap devices for OMAP4460 devices. > > Cc: "Benoît Cousson" <b-cousson@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Russell King <linux@arm.linux.org.uk> > Cc: linux-omap@vger.kernel.org > Cc: devicetree-discuss@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi > index 2cf227c..e5bfbfe 100644 > --- a/arch/arm/boot/dts/omap4460.dtsi > +++ b/arch/arm/boot/dts/omap4460.dtsi > @@ -29,4 +29,13 @@ > <0 55 0x4>; > ti,hwmods = "debugss"; > }; > + > + bandgap { > + reg = <0x4a002260 0x4 > + 0x4a00232C 0x4 > + 0x4a002378 0x18>; > + compatible = "ti,omap4460-bandgap"; > + interrupts = <0 126 4>; /* talert */ > + ti,tshut-gpio = <86>; Why do you need a custom attribute for GPIO? Cannot you use the standard one? Where is the gpio controller phandle? Usually it looks like this: gpios = <&gpio1 8 0>; Regards, Benoit ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-15 15:23 ` Benoit Cousson @ 2013-05-15 16:36 ` Eduardo Valentin 2013-05-15 16:57 ` Jean-Christophe PLAGNIOL-VILLARD 2013-05-16 7:20 ` Benoit Cousson 0 siblings, 2 replies; 18+ messages in thread From: Eduardo Valentin @ 2013-05-15 16:36 UTC (permalink / raw) To: Benoit Cousson Cc: Russell King, tony, devicetree-discuss, linux-kernel, Eduardo Valentin, linux-omap, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 1647 bytes --] On 15-05-2013 11:23, Benoit Cousson wrote: > Hi Eduardo, > > On 05/15/2013 04:58 PM, Eduardo Valentin wrote: >> Include bandgap devices for OMAP4460 devices. >> >> Cc: "Benoît Cousson" <b-cousson@ti.com> >> Cc: Tony Lindgren <tony@atomide.com> >> Cc: Russell King <linux@arm.linux.org.uk> >> Cc: linux-omap@vger.kernel.org >> Cc: devicetree-discuss@lists.ozlabs.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> >> --- >> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi >> index 2cf227c..e5bfbfe 100644 >> --- a/arch/arm/boot/dts/omap4460.dtsi >> +++ b/arch/arm/boot/dts/omap4460.dtsi >> @@ -29,4 +29,13 @@ >> <0 55 0x4>; >> ti,hwmods = "debugss"; >> }; >> + >> + bandgap { >> + reg = <0x4a002260 0x4 >> + 0x4a00232C 0x4 >> + 0x4a002378 0x18>; >> + compatible = "ti,omap4460-bandgap"; >> + interrupts = <0 126 4>; /* talert */ >> + ti,tshut-gpio = <86>; > > Why do you need a custom attribute for GPIO? Cannot you use the standard > one? I believe it was by your suggestion :-), during the first attempts to send this driver. But could not find the thread link :-( sorry. I guess the reasoning to mark it as a ti specific is because it will be used as IRQ line to treat thermal shutdown (in SW). > > Where is the gpio controller phandle? > > Usually it looks like this: > > gpios = <&gpio1 8 0>; > > > Regards, > Benoit > > > [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 295 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-15 16:36 ` Eduardo Valentin @ 2013-05-15 16:57 ` Jean-Christophe PLAGNIOL-VILLARD 2013-05-16 12:29 ` Eduardo Valentin 2013-05-16 7:20 ` Benoit Cousson 1 sibling, 1 reply; 18+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-05-15 16:57 UTC (permalink / raw) To: Eduardo Valentin Cc: Benoit Cousson, Russell King, tony, devicetree-discuss, linux-kernel, linux-omap, linux-arm-kernel On 12:36 Wed 15 May , Eduardo Valentin wrote: > On 15-05-2013 11:23, Benoit Cousson wrote: > > Hi Eduardo, > > > > On 05/15/2013 04:58 PM, Eduardo Valentin wrote: > >> Include bandgap devices for OMAP4460 devices. > >> > >> Cc: "Benoît Cousson" <b-cousson@ti.com> > >> Cc: Tony Lindgren <tony@atomide.com> > >> Cc: Russell King <linux@arm.linux.org.uk> > >> Cc: linux-omap@vger.kernel.org > >> Cc: devicetree-discuss@lists.ozlabs.org > >> Cc: linux-arm-kernel@lists.infradead.org > >> Cc: linux-kernel@vger.kernel.org > >> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > >> --- > >> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi > >> index 2cf227c..e5bfbfe 100644 > >> --- a/arch/arm/boot/dts/omap4460.dtsi > >> +++ b/arch/arm/boot/dts/omap4460.dtsi > >> @@ -29,4 +29,13 @@ > >> <0 55 0x4>; > >> ti,hwmods = "debugss"; > >> }; > >> + > >> + bandgap { > >> + reg = <0x4a002260 0x4 > >> + 0x4a00232C 0x4 > >> + 0x4a002378 0x18>; > >> + compatible = "ti,omap4460-bandgap"; > >> + interrupts = <0 126 4>; /* talert */ > >> + ti,tshut-gpio = <86>; > > > > > > > Why do you need a custom attribute for GPIO? Cannot you use the standard > > one? > > I believe it was by your suggestion :-), during the first attempts to > send this driver. But could not find the thread link :-( sorry. > > > I guess the reasoning to mark it as a ti specific is because it will be > used as IRQ line to treat thermal shutdown (in SW). so use interrup-parent > > > > > Where is the gpio controller phandle? > > > > Usually it looks like this: > > > > gpios = <&gpio1 8 0>; > > > > > > Regards, > > Benoit > > > > > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-15 16:57 ` Jean-Christophe PLAGNIOL-VILLARD @ 2013-05-16 12:29 ` Eduardo Valentin 2013-05-31 15:24 ` Jean-Christophe PLAGNIOL-VILLARD 0 siblings, 1 reply; 18+ messages in thread From: Eduardo Valentin @ 2013-05-16 12:29 UTC (permalink / raw) To: Jean-Christophe PLAGNIOL-VILLARD Cc: Eduardo Valentin, Benoit Cousson, Russell King, tony, devicetree-discuss, linux-kernel, linux-omap, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 2257 bytes --] On 15-05-2013 12:57, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 12:36 Wed 15 May , Eduardo Valentin wrote: >> On 15-05-2013 11:23, Benoit Cousson wrote: >>> Hi Eduardo, >>> >>> On 05/15/2013 04:58 PM, Eduardo Valentin wrote: >>>> Include bandgap devices for OMAP4460 devices. >>>> >>>> Cc: "Benoît Cousson" <b-cousson@ti.com> >>>> Cc: Tony Lindgren <tony@atomide.com> >>>> Cc: Russell King <linux@arm.linux.org.uk> >>>> Cc: linux-omap@vger.kernel.org >>>> Cc: devicetree-discuss@lists.ozlabs.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> >>>> --- >>>> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi >>>> index 2cf227c..e5bfbfe 100644 >>>> --- a/arch/arm/boot/dts/omap4460.dtsi >>>> +++ b/arch/arm/boot/dts/omap4460.dtsi >>>> @@ -29,4 +29,13 @@ >>>> <0 55 0x4>; >>>> ti,hwmods = "debugss"; >>>> }; >>>> + >>>> + bandgap { >>>> + reg = <0x4a002260 0x4 >>>> + 0x4a00232C 0x4 >>>> + 0x4a002378 0x18>; >>>> + compatible = "ti,omap4460-bandgap"; >>>> + interrupts = <0 126 4>; /* talert */ >>>> + ti,tshut-gpio = <86>; >> >> >> >>> >>> Why do you need a custom attribute for GPIO? Cannot you use the standard >>> one? >> >> I believe it was by your suggestion :-), during the first attempts to >> send this driver. But could not find the thread link :-( sorry. >> >> >> I guess the reasoning to mark it as a ti specific is because it will be >> used as IRQ line to treat thermal shutdown (in SW). > so use interrup-parent Jean-Christophe, That will change the controller and break the configuration for the other IRQ line, coming from GIC. >> >>> >>> Where is the gpio controller phandle? >>> >>> Usually it looks like this: >>> >>> gpios = <&gpio1 8 0>; >>> >>> >>> Regards, >>> Benoit >>> >>> >>> >> >> > > > >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 295 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-16 12:29 ` Eduardo Valentin @ 2013-05-31 15:24 ` Jean-Christophe PLAGNIOL-VILLARD 0 siblings, 0 replies; 18+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-05-31 15:24 UTC (permalink / raw) To: Eduardo Valentin, Grant Likely Cc: Benoit Cousson, Russell King, tony, devicetree-discuss, linux-kernel, linux-omap, linux-arm-kernel On 08:29 Thu 16 May , Eduardo Valentin wrote: > On 15-05-2013 12:57, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 12:36 Wed 15 May , Eduardo Valentin wrote: > >> On 15-05-2013 11:23, Benoit Cousson wrote: > >>> Hi Eduardo, > >>> > >>> On 05/15/2013 04:58 PM, Eduardo Valentin wrote: > >>>> Include bandgap devices for OMAP4460 devices. > >>>> > >>>> Cc: "Benoît Cousson" <b-cousson@ti.com> > >>>> Cc: Tony Lindgren <tony@atomide.com> > >>>> Cc: Russell King <linux@arm.linux.org.uk> > >>>> Cc: linux-omap@vger.kernel.org > >>>> Cc: devicetree-discuss@lists.ozlabs.org > >>>> Cc: linux-arm-kernel@lists.infradead.org > >>>> Cc: linux-kernel@vger.kernel.org > >>>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > >>>> --- > >>>> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ > >>>> 1 file changed, 9 insertions(+) > >>>> > >>>> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi > >>>> index 2cf227c..e5bfbfe 100644 > >>>> --- a/arch/arm/boot/dts/omap4460.dtsi > >>>> +++ b/arch/arm/boot/dts/omap4460.dtsi > >>>> @@ -29,4 +29,13 @@ > >>>> <0 55 0x4>; > >>>> ti,hwmods = "debugss"; > >>>> }; > >>>> + > >>>> + bandgap { > >>>> + reg = <0x4a002260 0x4 > >>>> + 0x4a00232C 0x4 > >>>> + 0x4a002378 0x18>; > >>>> + compatible = "ti,omap4460-bandgap"; > >>>> + interrupts = <0 126 4>; /* talert */ > >>>> + ti,tshut-gpio = <86>; > >> > >> > >> > >>> > >>> Why do you need a custom attribute for GPIO? Cannot you use the standard > >>> one? > >> > >> I believe it was by your suggestion :-), during the first attempts to > >> send this driver. But could not find the thread link :-( sorry. > >> > >> > >> I guess the reasoning to mark it as a ti specific is because it will be > >> used as IRQ line to treat thermal shutdown (in SW). > > so use interrup-parent > > > Jean-Christophe, > > That will change the controller and break the configuration for the > other IRQ line, coming from GIC. put this on hold I'm preparing a fix for this I've discuss with Grant already. This way for me is buggy Best Regards, J. > > >> > >>> > >>> Where is the gpio controller phandle? > >>> > >>> Usually it looks like this: > >>> > >>> gpios = <&gpio1 8 0>; > >>> > >>> > >>> Regards, > >>> Benoit > >>> > >>> > >>> > >> > >> > > > > > > > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-15 16:36 ` Eduardo Valentin 2013-05-15 16:57 ` Jean-Christophe PLAGNIOL-VILLARD @ 2013-05-16 7:20 ` Benoit Cousson 2013-05-16 12:27 ` Eduardo Valentin 1 sibling, 1 reply; 18+ messages in thread From: Benoit Cousson @ 2013-05-16 7:20 UTC (permalink / raw) To: Eduardo Valentin Cc: Russell King, tony, devicetree-discuss, linux-kernel, linux-omap, linux-arm-kernel Hi Eduardo, On 05/15/2013 06:36 PM, Eduardo Valentin wrote: > On 15-05-2013 11:23, Benoit Cousson wrote: >> Hi Eduardo, >> >> On 05/15/2013 04:58 PM, Eduardo Valentin wrote: >>> Include bandgap devices for OMAP4460 devices. >>> >>> Cc: "Benoît Cousson" <b-cousson@ti.com> >>> Cc: Tony Lindgren <tony@atomide.com> >>> Cc: Russell King <linux@arm.linux.org.uk> >>> Cc: linux-omap@vger.kernel.org >>> Cc: devicetree-discuss@lists.ozlabs.org >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: linux-kernel@vger.kernel.org >>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> >>> --- >>> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi >>> index 2cf227c..e5bfbfe 100644 >>> --- a/arch/arm/boot/dts/omap4460.dtsi >>> +++ b/arch/arm/boot/dts/omap4460.dtsi >>> @@ -29,4 +29,13 @@ >>> <0 55 0x4>; >>> ti,hwmods = "debugss"; >>> }; >>> + >>> + bandgap { >>> + reg = <0x4a002260 0x4 >>> + 0x4a00232C 0x4 >>> + 0x4a002378 0x18>; >>> + compatible = "ti,omap4460-bandgap"; >>> + interrupts = <0 126 4>; /* talert */ >>> + ti,tshut-gpio = <86>; > > > >> >> Why do you need a custom attribute for GPIO? Cannot you use the standard >> one? > > I believe it was by your suggestion :-), during the first attempts to > send this driver. But could not find the thread link :-( sorry. Ooops :-) I do not remember that... maybe it was long time ago, before we had any decent binding available for GPIO and IRQ... > I guess the reasoning to mark it as a ti specific is because it will be > used as IRQ line to treat thermal shutdown (in SW). Mmm, ok, so in that case, it is not even a gpio, but an interrupt entry that is needed like that: interrupt-parent = <&gpio3>; interrupts = <22>; /* gpio line 86 */ Except that we already have an IRQ line connected to GIC for the Talert... I'm not sure we can have 2 different IRQ controllers for one device :-( We need to check. Regards, Benoit >> Where is the gpio controller phandle? >> >> Usually it looks like this: >> >> gpios = <&gpio1 8 0>; >> >> >> Regards, >> Benoit >> >> >> > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-16 7:20 ` Benoit Cousson @ 2013-05-16 12:27 ` Eduardo Valentin 2013-05-29 14:11 ` Eduardo Valentin 0 siblings, 1 reply; 18+ messages in thread From: Eduardo Valentin @ 2013-05-16 12:27 UTC (permalink / raw) To: Benoit Cousson Cc: Russell King, tony, devicetree-discuss, linux-kernel, Eduardo Valentin, linux-omap, linux-arm-kernel [-- Attachment #1.1: Type: text/plain, Size: 2826 bytes --] On 16-05-2013 03:20, Benoit Cousson wrote: > Hi Eduardo, > > On 05/15/2013 06:36 PM, Eduardo Valentin wrote: >> On 15-05-2013 11:23, Benoit Cousson wrote: >>> Hi Eduardo, >>> >>> On 05/15/2013 04:58 PM, Eduardo Valentin wrote: >>>> Include bandgap devices for OMAP4460 devices. >>>> >>>> Cc: "Benoît Cousson" <b-cousson@ti.com> >>>> Cc: Tony Lindgren <tony@atomide.com> >>>> Cc: Russell King <linux@arm.linux.org.uk> >>>> Cc: linux-omap@vger.kernel.org >>>> Cc: devicetree-discuss@lists.ozlabs.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> >>>> --- >>>> arch/arm/boot/dts/omap4460.dtsi | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi >>>> index 2cf227c..e5bfbfe 100644 >>>> --- a/arch/arm/boot/dts/omap4460.dtsi >>>> +++ b/arch/arm/boot/dts/omap4460.dtsi >>>> @@ -29,4 +29,13 @@ >>>> <0 55 0x4>; >>>> ti,hwmods = "debugss"; >>>> }; >>>> + >>>> + bandgap { >>>> + reg = <0x4a002260 0x4 >>>> + 0x4a00232C 0x4 >>>> + 0x4a002378 0x18>; >>>> + compatible = "ti,omap4460-bandgap"; >>>> + interrupts = <0 126 4>; /* talert */ >>>> + ti,tshut-gpio = <86>; >> >> >> >>> >>> Why do you need a custom attribute for GPIO? Cannot you use the standard >>> one? >> >> I believe it was by your suggestion :-), during the first attempts to >> send this driver. But could not find the thread link :-( sorry. > > Ooops :-) I do not remember that... maybe it was long time ago, before > we had any decent binding available for GPIO and IRQ... > Probably it was because by that time we didnt have GPIO binding ready, yeah. >> I guess the reasoning to mark it as a ti specific is because it will be >> used as IRQ line to treat thermal shutdown (in SW). > > Mmm, ok, so in that case, it is not even a gpio, but an interrupt entry > that is needed like that: > > interrupt-parent = <&gpio3>; > interrupts = <22>; /* gpio line 86 */ > > Except that we already have an IRQ line connected to GIC for the > Talert... I'm not sure we can have 2 different IRQ controllers for one > device :-( > > We need to check. > Yeah, I also dont think this will work, because we will reparent the interrupt, setting to a different controller. That will break the TALERT signal already defined at GIC (check original patch). I propose keeping the way I sent. Unless there is a way to set two different controllers to same device. > Regards, > Benoit > > >>> Where is the gpio controller phandle? >>> >>> Usually it looks like this: >>> >>> gpios = <&gpio1 8 0>; >>> >>> >>> Regards, >>> Benoit >>> >>> >>> >> >> > > > [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 295 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-16 12:27 ` Eduardo Valentin @ 2013-05-29 14:11 ` Eduardo Valentin 2013-05-29 14:19 ` Cousson, Benoit 0 siblings, 1 reply; 18+ messages in thread From: Eduardo Valentin @ 2013-05-29 14:11 UTC (permalink / raw) To: Benoit Cousson Cc: Eduardo Valentin, tony, linux-omap, Russell King, devicetree-discuss, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 904 bytes --] Salut Monsieur Benoit, On 16-05-2013 08:27, Eduardo Valentin wrote: > On 16-05-2013 03:20, Benoit Cousson wrote: >> Hi Eduardo, >> <cut> >> We need to check. >> > > > Yeah, I also dont think this will work, because we will reparent the > interrupt, setting to a different controller. That will break the TALERT > signal already defined at GIC (check original patch). > > I propose keeping the way I sent. Unless there is a way to set two > different controllers to same device. > Any idea on this patch? Shall we keep the way it is? >> Regards, >> Benoit >> >> >>>> Where is the gpio controller phandle? >>>> >>>> Usually it looks like this: >>>> >>>> gpios = <&gpio1 8 0>; >>>> >>>> >>>> Regards, >>>> Benoit >>>> >>>> >>>> >>> >>> >> >> >> > > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 295 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-29 14:11 ` Eduardo Valentin @ 2013-05-29 14:19 ` Cousson, Benoit 2013-05-29 15:42 ` Eduardo Valentin 0 siblings, 1 reply; 18+ messages in thread From: Cousson, Benoit @ 2013-05-29 14:19 UTC (permalink / raw) To: Eduardo Valentin Cc: tony, linux-omap, Russell King, devicetree-discuss, linux-arm-kernel, linux-kernel Hi Eduardo, On 5/29/2013 4:11 PM, Eduardo Valentin wrote: > Salut Monsieur Benoit, > > On 16-05-2013 08:27, Eduardo Valentin wrote: >> On 16-05-2013 03:20, Benoit Cousson wrote: >>> Hi Eduardo, >>> > > <cut> > >>> We need to check. >> >> Yeah, I also dont think this will work, because we will reparent the >> interrupt, setting to a different controller. That will break the TALERT >> signal already defined at GIC (check original patch). >> >> I propose keeping the way I sent. Unless there is a way to set two >> different controllers to same device. >> > > Any idea on this patch? Shall we keep the way it is? Well since we cannot use directly interrupt, I think we need to use at least the proper gpio binding. Thanks, Benoit ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices 2013-05-29 14:19 ` Cousson, Benoit @ 2013-05-29 15:42 ` Eduardo Valentin 0 siblings, 0 replies; 18+ messages in thread From: Eduardo Valentin @ 2013-05-29 15:42 UTC (permalink / raw) To: Cousson, Benoit Cc: Eduardo Valentin, tony, linux-omap, Russell King, devicetree-discuss, linux-arm-kernel, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1059 bytes --] On 29-05-2013 10:19, Cousson, Benoit wrote: > Hi Eduardo, > > On 5/29/2013 4:11 PM, Eduardo Valentin wrote: >> Salut Monsieur Benoit, >> >> On 16-05-2013 08:27, Eduardo Valentin wrote: >>> On 16-05-2013 03:20, Benoit Cousson wrote: >>>> Hi Eduardo, >>>> >> >> <cut> >> >>>> We need to check. >>> >>> Yeah, I also dont think this will work, because we will reparent the >>> interrupt, setting to a different controller. That will break the TALERT >>> signal already defined at GIC (check original patch). >>> >>> I propose keeping the way I sent. Unless there is a way to set two >>> different controllers to same device. >>> >> >> Any idea on this patch? Shall we keep the way it is? > > Well since we cannot use directly interrupt, I think we need to use at > least the proper gpio binding. > hmm... OK. sounds reasonable. I will change the driver and resend this one in one single series. > Thanks, > Benoit > > > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 295 bytes --] ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2013-06-04 12:42 UTC | newest] Thread overview: 18+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-05-15 14:58 [PATCHv2 0/3] arm: enable TI SoC thermal driver Eduardo Valentin 2013-05-15 14:58 ` [PATCHv2 1/3] arm: introduce config HAS_BANDGAP Eduardo Valentin 2013-05-31 15:03 ` Eduardo Valentin 2013-05-31 15:12 ` Fabio Estevam 2013-06-04 12:32 ` Eduardo Valentin 2013-06-04 12:42 ` [PATCHv3 " Eduardo Valentin 2013-05-15 14:58 ` [PATCHv2 2/3] arm: dts: add bandgap entry for OMAP443x devices Eduardo Valentin 2013-05-15 14:58 ` [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices Eduardo Valentin 2013-05-15 15:23 ` Benoit Cousson 2013-05-15 16:36 ` Eduardo Valentin 2013-05-15 16:57 ` Jean-Christophe PLAGNIOL-VILLARD 2013-05-16 12:29 ` Eduardo Valentin 2013-05-31 15:24 ` Jean-Christophe PLAGNIOL-VILLARD 2013-05-16 7:20 ` Benoit Cousson 2013-05-16 12:27 ` Eduardo Valentin 2013-05-29 14:11 ` Eduardo Valentin 2013-05-29 14:19 ` Cousson, Benoit 2013-05-29 15:42 ` Eduardo Valentin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).