public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-omap@vger.kernel.org
Subject: Re: v3.10-rc1: backlight brightness after boot on N900
Date: Thu, 16 May 2013 07:52:12 +0300	[thread overview]
Message-ID: <519465FC.9090002@ti.com> (raw)
In-Reply-To: <20130515171845.GB3157@blackmetal.musicnaut.iki.fi>

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

On 15/05/13 20:18, Aaro Koskinen wrote:
> Hi,
> 
> Is it expected that after boot you get 0 brightness i.e. a seemingly
> blank display on N900 with 3.10-rc1?
> 
> First thought after seeing a blank display was that the probe
> issues are still there, but everything was fine and after setting
> /sys/class/backlight/acx565akm/brightness you get a picture.
> 
> Just wondering how the initial brightness is determined anyway?

There were some small changes merged in v3.10 related to acx's
backlight, but they were removing dead code so I don't see how those
could affect...

Looking at the driver, the bl is initialized:

	if (md->has_bc)
		brightness = acx565akm_get_actual_brightness(md);
	else
		brightness = 0;

And has_bc is set only if the model is detected as MIPID_VER_ACX565AKM
(that's the panel in final N900, isn't it?). So what comes to my mind is
that either the model is detected wrong, or the
acx565akm_get_actual_brightness() which reads the current BL from the
panel happens to return 0, either because of an error, or because the
bootloader has set the BL to 0.

But why either of those would've changed with v3.10... No idea...

Can you add debug prints to see which code paths are taken there
(drivers/video/omap2/displays/panel-acx565akm.c, around line 580). The
panel model should also be printed with "omapfb: %s rev %02x LCD detected".

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  reply	other threads:[~2013-05-16  4:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 17:18 v3.10-rc1: backlight brightness after boot on N900 Aaro Koskinen
2013-05-16  4:52 ` Tomi Valkeinen [this message]
2013-05-17 18:25   ` Aaro Koskinen
2013-05-17 18:45     ` Tony Lindgren
2013-05-17 19:17       ` Aaro Koskinen
2013-05-17 21:51       ` Linus Walleij
2013-05-17 22:09         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519465FC.9090002@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox