* [PATCH v2] usb: omap2430: fix memleak in err case [not found] <5192E650.3070303@huawei.com> @ 2013-05-22 3:30 ` Libo Chen 2013-05-28 12:41 ` Libo Chen 2013-05-28 17:40 ` Sergei Shtylyov 0 siblings, 2 replies; 6+ messages in thread From: Libo Chen @ 2013-05-22 3:30 UTC (permalink / raw) To: balbi, gregkh, grant.likely, rob.herring, Li Zefan Cc: linux-usb, linux-omap, LKML, Sergei Shtylyov when omap_get_control_dev faild, we should release related platform_device * Changelog from v1: * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <sergei.shtylyov@cogentembedded.com> Signed-off-by: Libo Chen <libo.chen@huawei.com> --- drivers/usb/musb/omap2430.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 3551f1a..b626f19 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev) glue->control_otghs = omap_get_control_dev(); if (IS_ERR(glue->control_otghs)) { dev_vdbg(&pdev->dev, "Failed to get control device\n"); - return -ENODEV; + ret = -ENODEV; + goto err2; } } else { glue->control_otghs = ERR_PTR(-ENODEV); -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] usb: omap2430: fix memleak in err case 2013-05-22 3:30 ` [PATCH v2] usb: omap2430: fix memleak in err case Libo Chen @ 2013-05-28 12:41 ` Libo Chen 2013-05-28 15:34 ` Andy Shevchenko 2013-05-28 17:40 ` Sergei Shtylyov 1 sibling, 1 reply; 6+ messages in thread From: Libo Chen @ 2013-05-28 12:41 UTC (permalink / raw) To: balbi, gregkh, grant.likely, rob.herring, Li Zefan Cc: linux-usb, linux-omap, LKML, Sergei Shtylyov ping... On 2013/5/22 11:30, Libo Chen wrote: > > when omap_get_control_dev faild, we should release related platform_device > > * Changelog from v1: > * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <sergei.shtylyov@cogentembedded.com> > > Signed-off-by: Libo Chen <libo.chen@huawei.com> > --- > drivers/usb/musb/omap2430.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c > index 3551f1a..b626f19 100644 > --- a/drivers/usb/musb/omap2430.c > +++ b/drivers/usb/musb/omap2430.c > @@ -549,7 +549,8 @@ static int omap2430_probe(struct platform_device *pdev) > glue->control_otghs = omap_get_control_dev(); > if (IS_ERR(glue->control_otghs)) { > dev_vdbg(&pdev->dev, "Failed to get control device\n"); > - return -ENODEV; > + ret = -ENODEV; > + goto err2; > } > } else { > glue->control_otghs = ERR_PTR(-ENODEV); > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] usb: omap2430: fix memleak in err case 2013-05-28 12:41 ` Libo Chen @ 2013-05-28 15:34 ` Andy Shevchenko 2013-05-29 0:52 ` Libo Chen 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2013-05-28 15:34 UTC (permalink / raw) To: Libo Chen Cc: balbi, Greg Kroah-Hartman, Grant Likely, Rob Herring, Li Zefan, USB, Linux OMAP Mailing List, LKML, Sergei Shtylyov No go. Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a And update you tree, please. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] usb: omap2430: fix memleak in err case 2013-05-28 15:34 ` Andy Shevchenko @ 2013-05-29 0:52 ` Libo Chen 0 siblings, 0 replies; 6+ messages in thread From: Libo Chen @ 2013-05-29 0:52 UTC (permalink / raw) To: Andy Shevchenko Cc: balbi, Greg Kroah-Hartman, Grant Likely, Rob Herring, Li Zefan, USB, Linux OMAP Mailing List, LKML, Sergei Shtylyov On 2013/5/28 23:34, Andy Shevchenko wrote: > No go. > > Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a > And update you tree, please. > > -- > With Best Regards, > Andy Shevchenko > > It had been changed :( Thanks, Libo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] usb: omap2430: fix memleak in err case 2013-05-22 3:30 ` [PATCH v2] usb: omap2430: fix memleak in err case Libo Chen 2013-05-28 12:41 ` Libo Chen @ 2013-05-28 17:40 ` Sergei Shtylyov 2013-05-29 2:47 ` Libo Chen 1 sibling, 1 reply; 6+ messages in thread From: Sergei Shtylyov @ 2013-05-28 17:40 UTC (permalink / raw) To: Libo Chen Cc: balbi, gregkh, grant.likely, rob.herring, Li Zefan, linux-usb, linux-omap, LKML Hello. On 22-05-2013 7:30, Libo Chen wrote: > when omap_get_control_dev faild, we should release related platform_device > * Changelog from v1: > * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <sergei.shtylyov@cogentembedded.com> It seems you've actually replaced "fail" with "faild", not "fails". > Signed-off-by: Libo Chen <libo.chen@huawei.com> > --- > drivers/usb/musb/omap2430.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) WBR, Sergei ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] usb: omap2430: fix memleak in err case 2013-05-28 17:40 ` Sergei Shtylyov @ 2013-05-29 2:47 ` Libo Chen 0 siblings, 0 replies; 6+ messages in thread From: Libo Chen @ 2013-05-29 2:47 UTC (permalink / raw) To: Sergei Shtylyov Cc: balbi, gregkh, grant.likely, rob.herring, Li Zefan, linux-usb, linux-omap, LKML On 2013/5/29 1:40, Sergei Shtylyov wrote: > Hello. > > On 22-05-2013 7:30, Libo Chen wrote: > >> when omap_get_control_dev faild, we should release related platform_device > >> * Changelog from v1: >> * fix spell: s/fail/fails/, s/relational/related/ , thank Sergei <sergei.shtylyov@cogentembedded.com> > > It seems you've actually replaced "fail" with "faild", not "fails". sorry for my weak spell. thanks again, Libo > >> Signed-off-by: Libo Chen <libo.chen@huawei.com> >> --- >> drivers/usb/musb/omap2430.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) > > WBR, Sergei > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-29 2:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5192E650.3070303@huawei.com>
2013-05-22 3:30 ` [PATCH v2] usb: omap2430: fix memleak in err case Libo Chen
2013-05-28 12:41 ` Libo Chen
2013-05-28 15:34 ` Andy Shevchenko
2013-05-29 0:52 ` Libo Chen
2013-05-28 17:40 ` Sergei Shtylyov
2013-05-29 2:47 ` Libo Chen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).