From: Florian Vaussard <florian.vaussard@epfl.ch>
To: "Andreas Müller" <schnitzeltony@googlemail.com>
Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] board-overo.c: enable TWL4030 power off
Date: Wed, 29 May 2013 10:34:18 +0200 [thread overview]
Message-ID: <51A5BD8A.10702@epfl.ch> (raw)
In-Reply-To: <CALbNGRQbAq4NdS4JFmJABG_kwOWsHeY9xOuk=x7AzCk3zb9eBA@mail.gmail.com>
Hello Andreas,
On 03/05/2013 09:15 AM, Andreas Müller wrote:
> On Mon, Mar 4, 2013 at 8:00 PM, Tony Lindgren <tony@atomide.com> wrote:
>> * Andreas Müller <schnitzeltony@googlemail.com> [130228 04:50]:
>>
>> Can you please add a description here? Preferrably something
>> like "With commit XYZ overo poweroff stopped working. Fix this
>> by blah blah blah" so this can be queued as a fix.
>>
>> Regards,
>>
>> Tony
>>
>>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>>> ---
>>> arch/arm/mach-omap2/board-overo.c | 5 +++++
>>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
>>> index 86bab51..b975c72 100644
>>> --- a/arch/arm/mach-omap2/board-overo.c
>>> +++ b/arch/arm/mach-omap2/board-overo.c
>>> @@ -418,9 +418,14 @@ static struct regulator_init_data overo_vmmc1 = {
>>> .consumer_supplies = overo_vmmc1_supply,
>>> };
>>>
>>> +static struct twl4030_power_data overo_power_data = {
>>> + .use_poweroff = true,
>>> +};
>>> +
>>> static struct twl4030_platform_data overo_twldata = {
>>> .gpio = &overo_gpio_data,
>>> .vmmc1 = &overo_vmmc1,
>>> + .power = &overo_power_data,
>>> };
>>>
>>> static int __init overo_i2c_init(void)
>>> --
> Sorry for the noise but I am newbie here and have one question:
> Against which branch should patches send here be based on. Up to now I
> used Linus' mainline branch - is that OK?
>
Any plans to repost your patch?
Regards,
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-05-29 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 12:44 [PATCH] board-overo.c: enable TWL4030 power off Andreas Müller
2013-03-04 19:00 ` Tony Lindgren
2013-03-05 8:09 ` Andreas Müller
2013-03-05 8:15 ` Andreas Müller
2013-03-05 18:43 ` Tony Lindgren
2013-05-29 8:34 ` Florian Vaussard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A5BD8A.10702@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=linux-omap@vger.kernel.org \
--cc=schnitzeltony@googlemail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox