* [PATCH] gpio/omap: omap_gpio_init_context stub must be inline
@ 2013-05-31 15:59 Arnd Bergmann
2013-06-05 15:38 ` Tony Lindgren
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2013-05-31 15:59 UTC (permalink / raw)
To: Linus Walleij, linux-gpio, linux-omap, linux-arm-kernel
Cc: Tony Lindgren, Jon Hunter, Santosh Shilimkar, Kevin Hilman
The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised"
has caused a new warning for omap1_defconfig:
drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function]
static void omap_gpio_init_context(struct gpio_bank *p) {}
^
The solution is to mark the stub function as 'static inline' so
it gets left out of the build when unused.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index d3f7d2d..e5fba65 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1462,7 +1462,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank)
#else
#define omap_gpio_runtime_suspend NULL
#define omap_gpio_runtime_resume NULL
-static void omap_gpio_init_context(struct gpio_bank *p) {}
+static inline void omap_gpio_init_context(struct gpio_bank *p) {}
#endif
static const struct dev_pm_ops gpio_pm_ops = {
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline
2013-05-31 15:59 [PATCH] gpio/omap: omap_gpio_init_context stub must be inline Arnd Bergmann
@ 2013-06-05 15:38 ` Tony Lindgren
2013-06-05 16:04 ` Santosh Shilimkar
2013-06-17 6:27 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-06-05 15:38 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, linux-gpio, linux-omap, linux-arm-kernel,
Jon Hunter, Santosh Shilimkar, Kevin Hilman
* Arnd Bergmann <arnd@arndb.de> [130531 09:05]:
> The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised"
> has caused a new warning for omap1_defconfig:
>
> drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function]
> static void omap_gpio_init_context(struct gpio_bank *p) {}
> ^
>
> The solution is to mark the stub function as 'static inline' so
> it gets left out of the build when unused.
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index d3f7d2d..e5fba65 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1462,7 +1462,7 @@ static void omap_gpio_restore_context(struct gpio_bank *bank)
> #else
> #define omap_gpio_runtime_suspend NULL
> #define omap_gpio_runtime_resume NULL
> -static void omap_gpio_init_context(struct gpio_bank *p) {}
> +static inline void omap_gpio_init_context(struct gpio_bank *p) {}
> #endif
>
> static const struct dev_pm_ops gpio_pm_ops = {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline
2013-05-31 15:59 [PATCH] gpio/omap: omap_gpio_init_context stub must be inline Arnd Bergmann
2013-06-05 15:38 ` Tony Lindgren
@ 2013-06-05 16:04 ` Santosh Shilimkar
2013-06-17 6:27 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Santosh Shilimkar @ 2013-06-05 16:04 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, linux-gpio, linux-omap, linux-arm-kernel,
Tony Lindgren, Kevin Hilman
On Friday 31 May 2013 11:59 AM, Arnd Bergmann wrote:
> The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised"
> has caused a new warning for omap1_defconfig:
>
> drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function]
> static void omap_gpio_init_context(struct gpio_bank *p) {}
> ^
>
> The solution is to mark the stub function as 'static inline' so
> it gets left out of the build when unused.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline
2013-05-31 15:59 [PATCH] gpio/omap: omap_gpio_init_context stub must be inline Arnd Bergmann
2013-06-05 15:38 ` Tony Lindgren
2013-06-05 16:04 ` Santosh Shilimkar
@ 2013-06-17 6:27 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-06-17 6:27 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, linux-gpio, Linux-OMAP,
linux-arm-kernel@lists.infradead.org, Tony Lindgren, Jon Hunter,
Santosh Shilimkar, Kevin Hilman
On Fri, May 31, 2013 at 5:59 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised"
> has caused a new warning for omap1_defconfig:
>
> drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function]
> static void omap_gpio_init_context(struct gpio_bank *p) {}
> ^
>
> The solution is to mark the stub function as 'static inline' so
> it gets left out of the build when unused.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied with Tony's and Santosh's ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-17 6:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-31 15:59 [PATCH] gpio/omap: omap_gpio_init_context stub must be inline Arnd Bergmann
2013-06-05 15:38 ` Tony Lindgren
2013-06-05 16:04 ` Santosh Shilimkar
2013-06-17 6:27 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).