From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: i2c issue on Panda with DT boot, v3.10-rc4
Date: Fri, 7 Jun 2013 15:47:16 +0300 [thread overview]
Message-ID: <51B1D654.9070107@ti.com> (raw)
In-Reply-To: <51B1D3D6.2020803@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]
On 07/06/13 15:36, Grygorii Strashko wrote:
> Could you check if below change will help you, pls?
> iff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 13d1eca..66a62e7 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -615,11 +615,11 @@ static int omap_i2c_xfer_msg(struct i2c_adapter
> *adap,
> if (dev->cmd_err & OMAP_I2C_STAT_NACK) {
> if (msg->flags & I2C_M_IGNORE_NAK)
> return 0;
> - if (stop) {
> - w = omap_i2c_read_reg(dev, OMAP_I2C_CON_REG);
> - w |= OMAP_I2C_CON_STP;
> - omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, w);
> - }
> +
> + w = omap_i2c_read_reg(dev, OMAP_I2C_CON_REG);
> + w |= OMAP_I2C_CON_STP;
> + omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, w);
> +
> return -EREMOTEIO;
> }
> return -EIO;
With that one, I don't get timeouts, but it still doesn't work (i.e.
behavior is the same as on -rc1).
When I run i2cdump the first time, I see that it (probably) manages to
read the first byte, as that's "00". Everything after that are 'XX'es.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-06-07 12:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 11:53 i2c issue on Panda with DT boot, v3.10-rc4 Tomi Valkeinen
2013-06-07 12:36 ` Grygorii Strashko
2013-06-07 12:47 ` Tomi Valkeinen [this message]
2013-06-07 17:57 ` Tony Lindgren
2013-06-07 18:31 ` Valkeinen, Tomi
2013-06-07 18:36 ` Tony Lindgren
2013-06-10 9:29 ` Tomi Valkeinen
2013-06-10 14:28 ` Tony Lindgren
2013-06-07 18:26 ` Felipe Balbi
2013-06-07 18:39 ` Felipe Balbi
2013-06-10 9:26 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B1D654.9070107@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).