From: Laxman Dewangan <ldewangan@nvidia.com>
To: Graeme Gregory <gg@slimlogic.co.uk>
Cc: J Keerthy <j-keerthy@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: Palmas: Introduce features to select the appropriate modules present in the palmas variant
Date: Fri, 14 Jun 2013 15:32:01 +0530 [thread overview]
Message-ID: <51BAEA19.7070509@nvidia.com> (raw)
In-Reply-To: <20130614095554.GF5456@mint>
On Friday 14 June 2013 03:25 PM, Graeme Gregory wrote:
> On Fri, Jun 14, 2013 at 02:51:58PM +0530, J Keerthy wrote:
>> - children[PALMAS_PMIC_ID].platform_data = pdata->pmic_pdata;
>> - children[PALMAS_PMIC_ID].pdata_size = sizeof(*pdata->pmic_pdata);
>> + if (PALMAS_PMIC_HAS(palmas, REGULATORS)) {
>> + children[PALMAS_PMIC_ID].platform_data = pdata->pmic_pdata;
>> + children[PALMAS_PMIC_ID].pdata_size =
>> + sizeof(*pdata->pmic_pdata);
>> + }
>>
> I think a lot of complexity here could actually be removed by removing the
> old board file style probing for palmas. I do not beleive either major user
> of palmas requires that anymore? I always had in my mind that this bit
> was temporary.
Completely agree, we should not have this. Also this is not valid much
in DT context and so we can remove it.
next prev parent reply other threads:[~2013-06-14 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:21 [PATCH] mfd: Palmas: Introduce features to select the appropriate modules present in the palmas variant J Keerthy
2013-06-14 9:55 ` Graeme Gregory
2013-06-14 10:02 ` Laxman Dewangan [this message]
2013-06-14 10:22 ` J, KEERTHY
2013-06-14 10:35 ` Graeme Gregory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BAEA19.7070509@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).