[PATCH] ARM: dts: omap3-beagle: fix the USB phy node

[PATCH] ARM: dts: omap3-beagle: fix the USB phy node

[Sebastian Andrzej Siewior]

I haven't tested this but it should not work the way it is now. The
format for of_parse_phandle() is usuall "phandle index" not the other
way around.

Cc: Benoît Cousson <b-cousson@ti.com>
Cc: Roger Quadros <rogerq@ti.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 arch/arm/boot/dts/omap3-beagle.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts
index 6eec699..a12e9b0 100644
--- a/arch/arm/boot/dts/omap3-beagle.dts
+++ b/arch/arm/boot/dts/omap3-beagle.dts
@@ -128,7 +128,7 @@
 };
 
 &usbhsehci {
-	phys = <0 &hsusb2_phy>;
+	phys = <&hsusb2_phy 0>;
 };
 
 &twl_gpio {
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: omap3-beagle: fix the USB phy node

[Sebastian Andrzej Siewior]

On 06/17/2013 03:27 PM, Sebastian Andrzej Siewior wrote:
> index 6eec699..a12e9b0 100644
> --- a/arch/arm/boot/dts/omap3-beagle.dts
> +++ b/arch/arm/boot/dts/omap3-beagle.dts
> @@ -128,7 +128,7 @@
>  };
>  
>  &usbhsehci {
> -	phys = <0 &hsusb2_phy>;
> +	phys = <&hsusb2_phy 0>;
>  };
>  
>  &twl_gpio {

Wait. Or does it mean that the first phy is deactivated and we add
phyhandle 0 (which is the root node) to skip it?

I assume that now since we don't have a cells property (like
#gpio-cells for the gpio lookup).

So ignore it please…

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: omap3-beagle: fix the USB phy node

[Roger Quadros]

On 06/17/2013 04:54 PM, Sebastian Andrzej Siewior wrote:
> On 06/17/2013 03:27 PM, Sebastian Andrzej Siewior wrote:
>> index 6eec699..a12e9b0 100644
>> --- a/arch/arm/boot/dts/omap3-beagle.dts
>> +++ b/arch/arm/boot/dts/omap3-beagle.dts
>> @@ -128,7 +128,7 @@
>>  };
>>  
>>  &usbhsehci {
>> -	phys = <0 &hsusb2_phy>;
>> +	phys = <&hsusb2_phy 0>;
>>  };
>>  
>>  &twl_gpio {
> 
> Wait. Or does it mean that the first phy is deactivated and we add
> phyhandle 0 (which is the root node) to skip it?

Right, it is a list of PHY phandles and the first one is not used so 0
> 
> I assume that now since we don't have a cells property (like
> #gpio-cells for the gpio lookup).
> 
> So ignore it please…

OK.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html