Re: [PATCHv2 2/2] ARM: dts: AM33XX: Add support for IGEP AQUILA EXPANSION board.

[Florian Vaussard <florian.vaussard@epfl.ch>]

Hello Javier,

On 06/22/2013 04:48 PM, Javier Martinez Canillas wrote:
> On Thu, Jun 20, 2013 at 10:16 AM, Enric Balletbo i Serra <eballetbo@iseebcn.com>
> wrote:
>> The IGEP AQUILA EXPANSION board is a development platform for the IGEP COM
>> AQUILA AM335x boards.
>>
>> The board adds the following connectivity:
>>
>>      o USB OTG
>>      o USB HOST
>>      o HDMI
>>      o Ethernet
>>      o Serial Debug (3.3V)
>>      o 2x46 pin headers
>>      o EEPROM
>>
>> Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>> ---
>>   arch/arm/boot/dts/Makefile            |  1 +
>>   arch/arm/boot/dts/am335x-base0033.dts | 16 ++++++++++++++++
>>   2 files changed, 17 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/am335x-base0033.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 8e50761..cb675d2 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -154,6 +154,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>>          am335x-evm.dtb \
>>          am335x-evmsk.dtb \
>>          am335x-bone.dtb \
>> +       am335x-base0033.dtb \
>>          am3517-evm.dtb \
>>          am3517_mt_ventoux.dtb
>>   dtb-$(CONFIG_ARCH_ORION5X) += orion5x-lacie-ethernet-disk-mini-v2.dtb
>> diff --git a/arch/arm/boot/dts/am335x-base0033.dts
> b/arch/arm/boot/dts/am335x-base0033.dts
>> new file mode 100644
>> index 0000000..d6bb791
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/am335x-base0033.dts
>> @@ -0,0 +1,16 @@
>> +/*
>> + * am335x-base0033.dtsi - Device Tree file for IGEP AQUILA EXPANSION
>> + *
>> + * Copyright (C) 2013 ISEE 2007 SL - http://www.isee.biz
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#include "am335x-igep0033.dtsi"
>> +
>> +/ {
>> +       model = "IGEP COM AM335x on AQUILA Expansion";
>> +       compatible = "ti,am335x-base0033", "ti,am335x-igep0033", "ti,am33xx";
>> +};
>> --
>> 1.8.1.2
>>
>
> Hi Enric
>
> Just small comment. I think it's better to make it compatible with
> "isee,am335x-base0033", "isee,am335x-igep0033", "ti,am33xx" since these boards
> are manufactured by ISEE and not by Texas Instrument.
>
> I see that other boards such as the omap3-tobi.dts use the same convention that
> you are using here and make it compatible with "ti,omap3-tobi",
> "ti,omap3-overo", "ti,omap3" instead of something like "gumstix,omap3-tobi",
> "gumstix,omap3-overo", "ti,omap3" that I think it would be better.
>

Your approach makes sense to me, as the board manufacturer is the one of 
importance
here.

I rapidly looked at the OF norm (IEEE 1275), all I could find is that 
"compatible"
should follow the same convention that the "name" property:

"For plug-in devices, the value string shall begin with a company name 
string in
one of the following forms, followed by a comma (',')."

As for the form of the company name, it can be:

- an Organizationally Unique Identifier (OUI) assigned by IEEE
- "one to five uppercase letters representing the stock symbol of the 
company on
any stock exchange"
- any other string, as long as it cannot be confused with one of the two 
above-
mentioned form

> But maybe I'm just wrong and misunderstanding the convention on how to define
> the compatible string for boards.
>

I do not know either, but I agree with you.

Regards,
Florian