MMC breakage on 3.11/cleanup

MMC breakage on 3.11/cleanup

[Joel A Fernandes]

Hi Tony,

Following branch breaks MMC for me on am33xx (beaglebone):
http://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.11/cleanup

I tried to work around it by specifying interrupt and reg property in DT:
      mmc1: mmc@48060000 {
         compatible = "ti,omap3-hsmmc";
         ti,hwmods = "mmc1";
         ti,dual-volt;
         ti,needs-special-reset;
         dmas = <&edma 24
            &edma 25>;
         dma-names = "tx", "rx";
         interrupts = <64>;
         interrupt-parent = <&intc>;
         reg = <0x48060000 0x1000>;
         status = "disabled";
      };

The probe succeeds but I still get a "Waiting for root device
/dev/mmcblk0p2" when booting over MMC.

If you're planning to push the cleanup branch, can we temporarily add
the hwmod data back while we work on this issue so that upstream MMC
is kept working.

Thanks,

-Joel

Re: MMC breakage on 3.11/cleanup

[Balaji T K]

On Tuesday 25 June 2013 03:57 AM, Joel A Fernandes wrote:
> Hi Tony,
>
> Following branch breaks MMC for me on am33xx (beaglebone):
> http://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.11/cleanup
>
> I tried to work around it by specifying interrupt and reg property in DT:
>        mmc1: mmc@48060000 {
>           compatible = "ti,omap3-hsmmc";
>           ti,hwmods = "mmc1";
>           ti,dual-volt;
>           ti,needs-special-reset;
>           dmas = <&edma 24
>              &edma 25>;
>           dma-names = "tx", "rx";
>           interrupts = <64>;
>           interrupt-parent = <&intc>;
>           reg = <0x48060000 0x1000>;
>           status = "disabled";
>        };
>
> The probe succeeds but I still get a "Waiting for root device
> /dev/mmcblk0p2" when booting over MMC.

Hi Joel,

Can you share your branch with edma + 3.11 cleanup, so that I can reproduce this
issue.

>
> If you're planning to push the cleanup branch, can we temporarily add
> the hwmod data back while we work on this issue so that upstream MMC
> is kept working.
>
> Thanks,
>
> -Joel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: MMC breakage on 3.11/cleanup

[Joel A Fernandes]

Hi Balaji,

> Can you share your branch with edma + 3.11 cleanup, so that I can reproduce
> this
> issue.

git@github.com:joelagnel/linux-kernel.git (branch dma-devel-mmc2)

Thanks,
Joel

Re: MMC breakage on 3.11/cleanup

[Tony Lindgren]

* Joel A Fernandes <agnel.joel@gmail.com> [130624 15:33]:
> Hi Tony,
> 
> Following branch breaks MMC for me on am33xx (beaglebone):
> http://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.11/cleanup
> 
> I tried to work around it by specifying interrupt and reg property in DT:
>       mmc1: mmc@48060000 {
>          compatible = "ti,omap3-hsmmc";
>          ti,hwmods = "mmc1";
>          ti,dual-volt;
>          ti,needs-special-reset;
>          dmas = <&edma 24
>             &edma 25>;
>          dma-names = "tx", "rx";
>          interrupts = <64>;
>          interrupt-parent = <&intc>;
>          reg = <0x48060000 0x1000>;
>          status = "disabled";
>       };
> 
> The probe succeeds but I still get a "Waiting for root device
> /dev/mmcblk0p2" when booting over MMC.
> 
> If you're planning to push the cleanup branch, can we temporarily add
> the hwmod data back while we work on this issue so that upstream MMC
> is kept working.

Yes the cleanup branch is queued up. Can you please send a patch
reverting the MMC parts of the hwmod change for am33xx for now,
then try to find the real cause for the breakage?

Regards,

Tony

Re: MMC breakage on 3.11/cleanup

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

On Mon, Jun 24, 2013 at 11:49:44PM -0700, Tony Lindgren wrote:
> * Joel A Fernandes <agnel.joel@gmail.com> [130624 15:33]:
> > Hi Tony,
> > 
> > Following branch breaks MMC for me on am33xx (beaglebone):
> > http://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.11/cleanup
> > 
> > I tried to work around it by specifying interrupt and reg property in DT:
> >       mmc1: mmc@48060000 {
> >          compatible = "ti,omap3-hsmmc";
> >          ti,hwmods = "mmc1";
> >          ti,dual-volt;
> >          ti,needs-special-reset;
> >          dmas = <&edma 24
> >             &edma 25>;
> >          dma-names = "tx", "rx";
> >          interrupts = <64>;
> >          interrupt-parent = <&intc>;
> >          reg = <0x48060000 0x1000>;
> >          status = "disabled";
> >       };
> > 
> > The probe succeeds but I still get a "Waiting for root device
> > /dev/mmcblk0p2" when booting over MMC.
> > 
> > If you're planning to push the cleanup branch, can we temporarily add
> > the hwmod data back while we work on this issue so that upstream MMC
> > is kept working.
> 
> Yes the cleanup branch is queued up. Can you please send a patch
> reverting the MMC parts of the hwmod change for am33xx for now,
> then try to find the real cause for the breakage?

I had mentioned that Joel should *not* depend on hwmod data and if
adding interrupts to DTS caused issues, that issue should be resolved.

http://marc.info/?l=linux-omap&m=137124891908957&w=2

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: MMC breakage on 3.11/cleanup

[Joel A Fernandes]

On Tue, Jun 25, 2013 at 5:40 AM, Felipe Balbi <balbi@ti.com> wrote:
> On Mon, Jun 24, 2013 at 11:49:44PM -0700, Tony Lindgren wrote:
>> * Joel A Fernandes <agnel.joel@gmail.com> [130624 15:33]:
>> > Hi Tony,
>> >
>> > Following branch breaks MMC for me on am33xx (beaglebone):
>> > http://git.kernel.org/cgit/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v3.11/cleanup
>> >
>> > I tried to work around it by specifying interrupt and reg property in DT:
>> >       mmc1: mmc@48060000 {
>> >          compatible = "ti,omap3-hsmmc";
>> >          ti,hwmods = "mmc1";
>> >          ti,dual-volt;
>> >          ti,needs-special-reset;
>> >          dmas = <&edma 24
>> >             &edma 25>;
>> >          dma-names = "tx", "rx";
>> >          interrupts = <64>;
>> >          interrupt-parent = <&intc>;
>> >          reg = <0x48060000 0x1000>;
>> >          status = "disabled";
>> >       };
>> >
>> > The probe succeeds but I still get a "Waiting for root device
>> > /dev/mmcblk0p2" when booting over MMC.
>> >
>> > If you're planning to push the cleanup branch, can we temporarily add
>> > the hwmod data back while we work on this issue so that upstream MMC
>> > is kept working.
>>
>> Yes the cleanup branch is queued up. Can you please send a patch
>> reverting the MMC parts of the hwmod change for am33xx for now,
>> then try to find the real cause for the breakage?
>
> I had mentioned that Joel should *not* depend on hwmod data and if
> adding interrupts to DTS caused issues, that issue should be resolved.
>
> http://marc.info/?l=linux-omap&m=137124891908957&w=2

Ofcourse, that is what we are talking about too. hwmod data is being
added only as a temporary fix to keep upstream working while we work
on a resolution.

Maybe you missed the "add the hwmod data back while we work on this
issue so that upstream MMC is kept working." in my post?

Please read,
  http://www.mail-archive.com/linux-omap@vger.kernel.org/msg91130.html


Thanks,

-Joel